After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597623 - Toggling an application in gnome-session-properties and closing too quickly causes changes to be lost
Toggling an application in gnome-session-properties and closing too quickly c...
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session-properties
2.28.x
Other Linux
: Normal minor
: ---
Assigned To: Session Maintainers
Session Maintainers
: 599246 599938 611596 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-10-06 23:52 UTC by Chris Coulson
Modified: 2010-03-07 12:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[capplet] Destroy the main window on close to ensure changes are saved (907 bytes, patch)
2009-10-11 20:34 UTC, Vincent Untz 		committed Details | Review

Description Chris Coulson 2009-10-06 23:52:42 UTC 
This was reported at: https://bugs.edge.launchpad.net/ubuntu/+source/gnome-session/+bug/444993:

"If the user checks or unchecks an application listed in the start applications window and quickly clicks on the close button, the changes to that application are not remembered. If however, the user checks or unchecks an application and waits about 5 seconds before hitting close, then the changes are stored."
Comment 1 Chris Coulson 2009-10-06 23:54:34 UTC 
This also applies to creating new entries in the dialog too
Comment 2 Vincent Untz 2009-10-07 00:28:03 UTC 
Hrm, I thought I had fixed this :/
Comment 3 Chris Coulson 2009-10-07 17:37:39 UTC 
Hmmmm, we still seem to be seeing this issue in 2.28.0 though
Comment 4 Vincent Untz 2009-10-11 20:34:27 UTC 
Created attachment 145254 [details] [review]
[capplet] Destroy the main window on close to ensure changes are saved

For some reasons, sometimes it works, and sometimes it doesn't. By
destroying the window, we make sure all objects are disposed and the
changes are saved.
Comment 5 Vincent Untz 2009-10-11 21:08:47 UTC 
Attachment 145254 [details] pushed as dd9df16 - [capplet] Destroy the main window on close to ensure changes are saved
Comment 6 Vincent Untz 2009-10-28 12:58:18 UTC 
*** Bug 599246 has been marked as a duplicate of this bug. ***
Comment 7 Vincent Untz 2009-10-28 19:35:25 UTC 
*** Bug 599938 has been marked as a duplicate of this bug. ***
Comment 8 Vincent Untz 2010-03-02 13:57:22 UTC 
*** Bug 611596 has been marked as a duplicate of this bug. ***
Comment 9 Wayne Sallee 2010-03-02 16:15:51 UTC 
There appears to be some confusion as to whether this has actually been fixed.

Is there a patch that I can test to check that this has indeed been fixed so that we don't go on to the next version, and still not have it fixed?
Comment 10 Vincent Untz 2010-03-02 16:19:49 UTC 
The patch is attached to this bug.
Comment 11 Wayne Sallee 2010-03-02 16:35:27 UTC 
What file needs modified?
I can't locate any "capplet/main.c".
Comment 12 Vincent Untz 2010-03-07 11:34:51 UTC 
Wayne: the file definitely exists, see http://git.gnome.org/browse/gnome-session/tree/capplet/main.c
Comment 13 Wayne Sallee 2010-03-07 12:24:34 UTC 
Thanks for pointing out the location.
I appreciate that.

Yea, after I posted I realized it was C code used to compile, and that was why I could not find it anywhere on my computer, and decided not to look for it anymore. :-)