GNOME Bugzilla – Bug 597594
remove mandatory gdkx includes?
Last modified: 2014-01-19 14:12:33 UTC
Just for fun, I tried building a Windows version of gThumb on Fedora using mingw, like this: yum install mingw* ./autogen.sh --host=i686-pc-mingw32 make but it fails because of this: [mjc@xena gthumb]$ make > eraseme In file included from eggdesktopfile.c:34: /usr/include/gtk-2.0/gdk/gdkx.h:32:22: error: X11/Xlib.h: No such file or directory /usr/include/gtk-2.0/gdk/gdkx.h:33:23: error: X11/Xutil.h: No such file or directory Anyway, I think the gdkx bits could be made optional. This would simplify compilation of Windows and MacOS ports. - Mike
Created attachment 266359 [details] [review] Remove gdkx include This patch removes the only gdkx include declaration without GDK_WINDOWING_X11 macro guard from the gthumb source code. The other references of gdkx.h are from the libegg, used for session management and desktop file management. Session management is implemented as far as I know in GtkApplication from more recent GLib, and desktop file management in GDesktopAppInfo (example on how to replace eggdesktopfile usage in [1]) However the decision whether to drop libegg support and use the glib support instead is one to take by the maintainers of gthumb, as some maintainers have refused to do this because it binds the application closely to the GTK+ framework (which IMHO should not be a problem, as gThumb is a GNOME application with headerbar support, already tying it to recent GTK+) [1] https://mail.gnome.org/archives/commits-list/2012-November/msg03031.html
Patch pushed to master, thank you
(In reply to comment #1) > Created an attachment (id=266359) [details] [review] > Remove gdkx include > > This patch removes the only gdkx include declaration without GDK_WINDOWING_X11 > macro guard from the gthumb source code. > > The other references of gdkx.h are from the libegg, used for session management > and desktop file management. Session management is implemented as far as I know > in GtkApplication from more recent GLib, and desktop file management in > GDesktopAppInfo (example on how to replace eggdesktopfile usage in [1]) > > However the decision whether to drop libegg support and use the glib support > instead is one to take by the maintainers of gthumb, as some maintainers have > refused to do this because it binds the application closely to the GTK+ > framework (which IMHO should not be a problem, as gThumb is a GNOME application > with headerbar support, already tying it to recent GTK+) > > [1] https://mail.gnome.org/archives/commits-list/2012-November/msg03031.html I've removed the libegg code now, thanks for the hint.