After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597586 - [AppWell] Workaround being allocated 0x0
[AppWell] Workaround being allocated 0x0
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-10-06 18:12 UTC by Colin Walters
Modified: 2009-10-06 19:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[AppWell] Workaround being allocated 0x0 (1.56 KB, patch)
2009-10-06 18:12 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2009-10-06 18:12:30 UTC
Because of a chain of bugs we could end up getting allocated 0x0,
and this would cause the WellGrid allocation code to be unhappy.

See http://bugzilla.openedhand.com/show_bug.cgi?id=1831

Simply treat 0 as "unlimited" i.e. equivalent to -1.
Comment 1 Colin Walters 2009-10-06 18:12:32 UTC
Created attachment 144903 [details] [review]
[AppWell] Workaround being allocated 0x0
Comment 2 Owen Taylor 2009-10-06 18:40:03 UTC
Review of attachment 144903 [details] [review]:

Patch looks good to me, the "chain of bugs ..." see "...=1831" formulation you use in the body and comment doesn't actually work out because I don't describe the Big.Box part of the chain in the bug report. More explicit alternate text:

 Big.Box will allocate us at 0x0 if we are not visible; this is probably a Big.Box bug but it can't be fixed because if children are skipped in allocate() Clutter gets confused (see http://bugzilla.openedhand.com/show_bug.cgi?id=1831)