GNOME Bugzilla – Bug 597528
CPUFreq scale icons should be themable
Last modified: 2013-02-11 22:25:02 UTC
Created attachment 144874 [details] [review] Patch to themable icons Currently cpufreq icons can't be overriden by a icon theme like indicator-applet, mixer or other applets; i've made a simple patch against version 2.28.0 that loads the icons from the current theme. if you place custom icons on a theme (I use status folder, since volume control icons are there) and add a cpufreq applet it shows the custom icons; you can try with these http://gnome-look.org/content/show.php/?content=113148 The patch doesn't add a callback for the theme change signal, neither changes installation location of the bundled icons in makefiles. Please let me know if this is right to continue fixing things (I know i need to make a path against CVS), this issue always bugged me since i started to use gnome and finally found some time to do something abut it. :]
Yes, this is right!, thank you very much for the patch. We don't use CVS anymore so you have to make the patch against git (see http://live.gnome.org/Git), although a patch against 2.28 tarball would be valid too. As you said the patch still needs some work: - Change the installation path in Makefile.am. See http://live.gnome.org/GnomeGoals/AppIcon - We need to add the icons to the default theme icon factory at startup. See GtkIconFactory documentation - Add a callback for the theme changed signal. Thanks!
Created attachment 145321 [details] [review] Patch to enable themable icons I've written a new patch against git head; it also applies to 2.28 (the one in ubuntu repositories). * Loads icons from icon themes ( cpufreq-<percentage> ie. ) adding a default icon factory on startup. * Modifies the makefile of the pixmaps to put them in $prefix/share/icons/hicolor/24x24/status following the Icon Theme Specification. * Connects to the GtkIconTheme change signal, so it loads icons from the new theme. your feedback is welcome.
Thanks for taking the time to report this bug. However, you are using a version that is too old and not supported anymore. GNOME developers are no longer working on that version, so unfortunately there will not be any bug fixes for the version that you use. By upgrading to a newer version of GNOME you could receive bug fixes and new functionality. You may need to upgrade your Linux distribution to obtain a newer version of GNOME. Please feel free to reopen this bug if the problem still occurs with a newer version of GNOME.