After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597480 - Fails to build with GTK+ 2.18
Fails to build with GTK+ 2.18
Status: RESOLVED FIXED
Product: guile-gnome
Classification: Other
Component: gtk
bzr trunk
Other Linux
: Normal major
: ---
Assigned To: Guile-GNOME maintainer(s)
Guile-GNOME maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-10-05 21:42 UTC by Andreas Rottmann
Modified: 2010-08-31 06:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix compilation error on gtk_widget_get_allocation() with GTK 2.18 (1.56 KB, patch)
2009-11-28 10:04 UTC, Patrick Bernaud
none Details | Review

Description Andreas Rottmann 2009-10-05 21:42:54 UTC
In GTK+ 2.18, gtk_widget_get_allocation() was added to GTK+; since guile-gnome has a definition for that function in its gtk-support.c file, it fails to build:

> /bin/bash ../../../libtool --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I. -I../../..    -I../../../glib/gnome/gobject -I../../../glib/gnome/gobject -I. -I. -Wall -g -D_REENTRANT -I/usr/include/guile-cairo -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12   -D_REENTRANT -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include    -std=gnu99    -g -O2 -g -Wall -O2 -c -o libgw_guile_gnome_gtk_la-guile-gtk-tree-model.lo `test -f 'guile-gtk-tree-model.c' || echo './'`guile-gtk-tree-model.c
> libtool: compile:  cc -DHAVE_CONFIG_H -I. -I../../.. -I../../../glib/gnome/gobject -I../../../glib/gnome/gobject -I. -I. -Wall -g -D_REENTRANT -I/usr/include/guile-cairo -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12 -D_REENTRANT -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -std=gnu99 -g -O2 -g -Wall -O2 -c guile-gtk-tree-model.c  -fPIC -DPIC -o .libs/libgw_guile_gnome_gtk_la-guile-gtk-tree-model.o
> In file included from guile-gtk-tree-model.c:33:
> gtk-support.h:120: error: conflicting types for 'gtk_widget_get_allocation'
> /usr/include/gtk-2.0/gtk/gtkwidget.h:621: error: previous declaration of 'gtk_widget_get_allocation' was here
> make[6]: *** [libgw_guile_gnome_gtk_la-guile-gtk-tree-model.lo] Error 1


Reported originally on the Debian BTS: <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=549752>.
Comment 1 Patrick Bernaud 2009-11-28 10:04:51 UTC
Created attachment 148640 [details] [review]
Fix compilation error on gtk_widget_get_allocation() with GTK 2.18
Comment 2 Patrick Bernaud 2009-11-28 10:05:27 UTC
Also note that, since GTK 2.18, it is not anymore possible to compile with 'Werror' turned on: the third argument of gtk_recent_info_get_application_info() is no more a 'gchar**' but a 'const gchar**', the build fails with an 'incompatible pointer type'. Passing '--disable-Werror' to configure fixes the problem.
Comment 3 Andy Wingo 2010-08-31 06:10:17 UTC
Applied, thanks :)