After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597471 - Use GtkIMContext instead of ClutterIMContext
Use GtkIMContext instead of ClutterIMContext
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-10-05 20:35 UTC by Owen Taylor
Modified: 2009-10-06 18:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use GtkIMContext instead of ClutterIMContext (22.42 KB, patch)
2009-10-05 20:35 UTC, Owen Taylor
committed Details | Review

Description Owen Taylor 2009-10-05 20:35:47 UTC
Add StIMText, which is a drop-in replacement for ClutterIMText but
uses GtkIMContext instead of ClutterIMContext.

StIMText doesn't have preedit support (would need ClutterText
changes), so isn't going to be useful for complicated input methods,
but is good enough to get dead keys and similar working.

entry.js: Simple test case of StEntry
gnome-shell.modules: Remove clutter-imcontext module
Comment 1 Owen Taylor 2009-10-05 20:35:48 UTC
Created attachment 144839 [details] [review]
Use GtkIMContext instead of ClutterIMContext
Comment 2 Dan Winship 2009-10-06 15:56:13 UTC
Comment on attachment 144839 [details] [review]
Use GtkIMContext instead of ClutterIMContext

>+ *  B) It doesn't surrounding context with the :retrieve-surrounding
>+ *     and :delete-surrounding signals.

something is missing there

Other that that, it all looks like a giant kludge, but it's a giant kludge that works, so...
Comment 3 Owen Taylor 2009-10-06 18:48:16 UTC
Pushed with a fixed comment.

Is it a kludge? Well the conversion of ClutterEvent to GtkEvent is a
kludge, but otherwise it really is a step towards hooking up Clutter
to GNOME's input method framework properly ... GtkIMContext was
designed to be relatively independent of specifics widgetry - e.g.,
the widget isn't passed to the IMContext.

[ It might be better to have a proper independent hookup between
  Clutter and input method frameworks like imbus instead of using
  the GTK+ hookup, but there's a lot of duplicate engineering that
  will have to be done to make that work ]

Attachment 144839 [details] pushed as 1cd64dd - Use GtkIMContext instead of ClutterIMContext