After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 59747 - Slightly better layout for GtkFileSelection
Slightly better layout for GtkFileSelection
Status: RESOLVED DUPLICATE of bug 29087
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
1.3.x
Other All
: Normal minor
: future
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2001-08-29 17:50 UTC by Skip Montanaro
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Skip Montanaro 2001-08-29 17:50:05 UTC
The button_area in the GtkFileSelection widget is a bit odd.  This patch
improves that layout and deletes the unused confirm_area variable from
gtk_file_selection_init.

-------------------------------------------------------

*** /tmp/skip/gtkfilesel.c.~1.84~eTA6Zk	Wed Aug 29 12:45:45 2001
--- /tmp/skip/gtkfilesel.ceTAHkq	Wed Aug 29 12:45:45 2001
***************
*** 585,591 ****
    GtkWidget *entry_vbox;
    GtkWidget *label;
    GtkWidget *list_hbox;
-   GtkWidget *confirm_area;
    GtkWidget *pulldown_hbox;
    GtkWidget *scrolled_win;
    GtkDialog *dialog;
--- 585,590 ----
***************
*** 603,612 ****
  
    /* The horizontal box containing create, rename etc. buttons */
    filesel->button_area = gtk_hbutton_box_new ();
!   gtk_button_box_set_layout (GTK_BUTTON_BOX (filesel->button_area),
GTK_BUTTONBOX_START);
    gtk_box_set_spacing (GTK_BOX (filesel->button_area), 0);
    gtk_box_pack_start (GTK_BOX (filesel->main_vbox), filesel->button_area, 
! 		      FALSE, FALSE, 0);
    gtk_widget_show (filesel->button_area);
    
    gtk_file_selection_show_fileop_buttons (filesel);
--- 602,612 ----
  
    /* The horizontal box containing create, rename etc. buttons */
    filesel->button_area = gtk_hbutton_box_new ();
!   gtk_button_box_set_layout (GTK_BUTTON_BOX (filesel->button_area),
! 			     GTK_BUTTONBOX_SPREAD);
    gtk_box_set_spacing (GTK_BOX (filesel->button_area), 0);
    gtk_box_pack_start (GTK_BOX (filesel->main_vbox), filesel->button_area, 
! 		      FALSE, FALSE, 5);
    gtk_widget_show (filesel->button_area);
    
    gtk_file_selection_show_fileop_buttons (filesel);
***************
*** 673,681 ****
  		      FALSE, FALSE, 0);
    gtk_widget_show (filesel->action_area);
    
-   /*  The OK/Cancel button area */
-   confirm_area = dialog->action_area;
- 
    /*  The OK button  */
    filesel->ok_button = gtk_dialog_add_button (dialog,
                                                GTK_STOCK_OK,
--- 673,678 ----
Comment 1 Owen Taylor 2001-09-19 15:58:01 UTC
I think the fileops buttons are just better left turned off for now
if you care about a decent GUI :-)
Comment 2 Federico Mena Quintero 2004-01-06 20:55:26 UTC
I'm marking this as a duplicate of the master #29087, "rework
GtkFileSelection widget", as it will get replaced with GtkFileChooser.

*** This bug has been marked as a duplicate of 29087 ***