GNOME Bugzilla – Bug 59747
Slightly better layout for GtkFileSelection
Last modified: 2004-12-22 21:47:04 UTC
The button_area in the GtkFileSelection widget is a bit odd. This patch improves that layout and deletes the unused confirm_area variable from gtk_file_selection_init. ------------------------------------------------------- *** /tmp/skip/gtkfilesel.c.~1.84~eTA6Zk Wed Aug 29 12:45:45 2001 --- /tmp/skip/gtkfilesel.ceTAHkq Wed Aug 29 12:45:45 2001 *************** *** 585,591 **** GtkWidget *entry_vbox; GtkWidget *label; GtkWidget *list_hbox; - GtkWidget *confirm_area; GtkWidget *pulldown_hbox; GtkWidget *scrolled_win; GtkDialog *dialog; --- 585,590 ---- *************** *** 603,612 **** /* The horizontal box containing create, rename etc. buttons */ filesel->button_area = gtk_hbutton_box_new (); ! gtk_button_box_set_layout (GTK_BUTTON_BOX (filesel->button_area), GTK_BUTTONBOX_START); gtk_box_set_spacing (GTK_BOX (filesel->button_area), 0); gtk_box_pack_start (GTK_BOX (filesel->main_vbox), filesel->button_area, ! FALSE, FALSE, 0); gtk_widget_show (filesel->button_area); gtk_file_selection_show_fileop_buttons (filesel); --- 602,612 ---- /* The horizontal box containing create, rename etc. buttons */ filesel->button_area = gtk_hbutton_box_new (); ! gtk_button_box_set_layout (GTK_BUTTON_BOX (filesel->button_area), ! GTK_BUTTONBOX_SPREAD); gtk_box_set_spacing (GTK_BOX (filesel->button_area), 0); gtk_box_pack_start (GTK_BOX (filesel->main_vbox), filesel->button_area, ! FALSE, FALSE, 5); gtk_widget_show (filesel->button_area); gtk_file_selection_show_fileop_buttons (filesel); *************** *** 673,681 **** FALSE, FALSE, 0); gtk_widget_show (filesel->action_area); - /* The OK/Cancel button area */ - confirm_area = dialog->action_area; - /* The OK button */ filesel->ok_button = gtk_dialog_add_button (dialog, GTK_STOCK_OK, --- 673,678 ----
I think the fileops buttons are just better left turned off for now if you care about a decent GUI :-)
I'm marking this as a duplicate of the master #29087, "rework GtkFileSelection widget", as it will get replaced with GtkFileChooser. *** This bug has been marked as a duplicate of 29087 ***