After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597422 - Run dialog: Make error message translatable
Run dialog: Make error message translatable
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-10-05 14:39 UTC by drago01
Modified: 2009-10-05 21:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make error message translatable (970 bytes, patch)
2009-10-05 14:39 UTC, drago01 		committed Details | Review

Description drago01 2009-10-05 14:39:01 UTC 
Created attachment 144797 [details] [review]
Make error message translatable

Allow the error message to be translated.
Comment 1 Owen Taylor 2009-10-05 21:50:03 UTC 
Comment on attachment 144797 [details] [review]
Make error message translatable

  let errorStr = _("Execution of '%s' failed:\n%s").format(command, m[1]);

Would be slightly better as:

  let errorStr = _("Execution of '%s' failed:").format(command) + "\n" + m[1];

Generally, the more you keep out of the translatable string, the happier translators are and the less chance for translators to break something

Otherwise looks fine to me.
Comment 2 drago01 2009-10-05 21:57:04 UTC 
Comment on attachment 144797 [details] [review]
Make error message translatable

Yeah that makes sense, committed with this change.