After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597167 - [ShellAppSystem] Cache applications for a menu
[ShellAppSystem] Cache applications for a menu
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-10-02 23:02 UTC by Colin Walters
Modified: 2009-10-02 23:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[ShellAppSystem] Cache applications for a menu (4.35 KB, patch)
2009-10-02 23:02 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2009-10-02 23:02:50 UTC
Rather than recomputing this each time someone asks, have a
cache of the apps for a given menu.
Comment 1 Colin Walters 2009-10-02 23:02:51 UTC
Created attachment 144633 [details] [review]
[ShellAppSystem] Cache applications for a menu
Comment 2 Marina Zhurakhinskaya 2009-10-02 23:25:48 UTC
Makes sense to me.

  * Traverses a toplevel menu, and returns all items under it.  Nested items
- * are flattened.
+ * are flattened.  This value is cached.

Can you change "This value is cached." to something like "The results are cached and returned if the function is called for the same menu again."