GNOME Bugzilla – Bug 597148
Set ShellTrayManager:bg-color to match panel
Last modified: 2009-10-04 08:07:04 UTC
ShellTrayManager has a bg-color property that is used as the background for icons that dont' support ARGB. But currently we have: // Used for the tray icon container with gtk pre-2.16, which doesn't // fully support tray icon transparency const TRAY_BACKGROUND_COLOR = new Clutter.Color(); TRAY_BACKGROUND_COLOR.from_pixel(0xefefefff); Which doesn't match our panel at all, which is a gradient from const BACKGROUND_TOP = new Clutter.Color(); BACKGROUND_TOP.from_pixel(0x161616ff); const BACKGROUND_BOTTOM = new Clutter.Color(); BACKGROUND_BOTTOM.from_pixel(0x000000ff); So TRAY_BACKGROUND_COLOR should be 0x080808ff instead. Implementing a background gradient for ShellTrayManager is possible - but I don't think the difference between the nearly-black-gradient and a nearly-black solid color will be that obvious.
Created attachment 144613 [details] [review] Use better fitting color for non ARGB tray icons I tested it 0xb0b0bff and it looks much better than before, it matches the panel good enough as is, so using a gradient as a background is not worth the effort here. The attached patch changes the color to 0xb0b0bff.
Comment on attachment 144613 [details] [review] Use better fitting color for non ARGB tray icons Patch needs: A) A commit body that explains the patch. See: http://article.gmane.org/gmane.comp.lib.cairo/14829 B) A link to the bug. (git-bz will take care of this for you if you use it to attach your patches.) We don't generally sign-off our own patches though it doesn't hurt.
(In reply to comment #2) > (From update of attachment 144613 [details] [review]) > Patch needs: > > A) A commit body that explains the patch. See: > > http://article.gmane.org/gmane.comp.lib.cairo/14829 OK > B) A link to the bug. (git-bz will take care of this for you if you use it to > attach your patches.) OK > We don't generally sign-off our own patches though it doesn't hurt. OK, I am used to always pass "-s" to git commit.
Created attachment 144619 [details] [review] Use better fitting color for non ARGB tray icons Added commit message, bugzilla link and removed the sign-off.
Comment on attachment 144619 [details] [review] Use better fitting color for non ARGB tray icons Two tiny things. comment has 'bakcground' Comment and code have '0xb0b0bff' which would be better as 0x0b0b0bff' - makes it clearer that all three components are the same.
Comment on attachment 144619 [details] [review] Use better fitting color for non ARGB tray icons Committed as 9b05304c2d58b8fc5f5e75c6a2ac2ec4523d4565 with the changes from #c5.