After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597144 - missing call to pclose
missing call to pclose
Status: RESOLVED FIXED
Product: gnome-commander
Classification: Other
Component: application
unspecified
Other Linux
: Normal normal
: 1.2.9
Assigned To: epiotr
epiotr
Depends on:
Blocks:
 
 
Reported: 2009-10-02 17:52 UTC by Vincent Untz
Modified: 2009-10-03 18:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Vincent Untz 2009-10-02 17:52:23 UTC 
Forwarding https://bugzilla.novell.com/show_bug.cgi?id=543762

I just had a look at factory package gnome-commander-1.2.8.1-1.8
source code file gnome-commander-1.2.8.1/src/utils.cc
function app_get_linked_libs
local variable fd.

I notice the following code

   FILE *fd = popen (cmd, "r");

but I fail to notice any matching call to pclose. This looks like a
resource leak to me. Suggest add a call to pclose near the end of the
block to plug the leak.
Comment 1 nm 2009-10-03 17:00:25 UTC 
Hello,

Could you create a patch for this bug?

I mean you have noticed the leak and seem to know the way around the code so maybe you could provide a patch to review?
Comment 2 epiotr 2009-10-03 18:21:11 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.