After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597131 - [timeline] Replace default sources by as-needed-sources
[timeline] Replace default sources by as-needed-sources
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: Playback
0.15
Other Linux
: Normal normal
: Git
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks: 610626
 
 
Reported: 2009-10-02 16:17 UTC by Edward Hervey
Modified: 2011-06-09 02:30 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Edward Hervey 2009-10-02 16:17:51 UTC
Currently we use default sources for audio and video so that when there are gaps in the compositions, it still outputs a valid source.

With timelines getting more and more complex (and the addition of videomixer), this is costing us a lot of extra processing for nothing.

We should therefore remove the default sources and replace them by a source whenever there is a gap in the timeline.

These sources must of course not be visible in the UI.

My best guest... is to make Gaps a certain kind of TimelineObjects, which are automatically added/removed/resized whenever there is a modification in the timeline.

Removing that $#@*($@# default source is one of the essential parts to start getting decent performance in the videomixer branch.
Comment 1 Jean-François Fortin Tam 2011-06-09 02:21:14 UTC
Edward, is this still the case?
Comment 2 Thibault Saunier 2011-06-09 02:30:51 UTC
commit a1d351158098a4e0b8eca77586ef7b2b4dda5207
Author: Brandon Lewis <brandon_lewis@alum.berkeley.edu>
Date:   Thu Dec 3 19:42:26 2009 -0800

    track.py: use gap-finding code to handle multiple default sources
    basically brute-force approach: keep a list of sources added, remove previous
    sources, find new gap list, add new sources.