After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597059 - Make statusbar info string translatable
Make statusbar info string translatable
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: image viewer
git master
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-02 00:59 UTC by Khaled Hosny
Modified: 2009-10-09 17:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make statusbar info string translatable (927 bytes, patch)
2009-10-02 00:59 UTC, Khaled Hosny
accepted-commit_after_freeze Details | Review
Screenshot (9.25 KB, image/png)
2009-10-02 01:00 UTC, Khaled Hosny
  Details
New patch (1.79 KB, patch)
2009-10-09 15:30 UTC, Khaled Hosny
accepted-commit_now Details | Review

Description Khaled Hosny 2009-10-02 00:59:15 UTC
Created attachment 144560 [details] [review]
Make statusbar info string translatable

Currently, only the pixel/pixels part of statusbar string is translatable, but
this doesn't fit well for Arabic l10n (and may be other languages):
- We need to insert RLM at the start of the string, otherwise the status
message will be completely out of order and thus useless, this has been
annoying me for years (see the screenshot)
- We need to use the multiplication symbol "×" instead of the letter "x",
because the later is string LTR char and thus breaks RTL order
- In this specific context, pixel in Arabic is always singular, but the
pixel/pixels string is used in other places and sharing one translation for it
isn't appropriate

The attached patch should fix this.
Comment 1 Khaled Hosny 2009-10-02 01:00:46 UTC
Created attachment 144561 [details]
Screenshot

This compares statusbar befor and after applying the patch and adjusting the translation.
Comment 2 Felix Riemann 2009-10-06 10:16:01 UTC
Comment on attachment 144560 [details] [review]
Make statusbar info string translatable

I see. Will apply it after branching.

What about the image counter (on the left)? Shouldn't that be made translatable as well for similar reasons?
Comment 3 Khaled Hosny 2009-10-06 12:09:45 UTC
(In reply to comment #2)
> (From update of attachment 144560 [details] [review])
> I see. Will apply it after branching.
What about applying it now and updating the existing translations as well. Since the string was built from existing translation it should be a straight forward job (if it is OK, I can do it),  after branching we can make it fuzzy so translators can look at.

> What about the image counter (on the left)? Shouldn't that be made translatable
> as well for similar reasons?

The counter is composed of numbers only, that need no special handling for Arabic but some locales would prefer using %Id for localized numbers, so I think it'd better be translatable too.
Comment 4 Felix Riemann 2009-10-06 13:37:39 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 144560 [details] [review] [details])
> > I see. Will apply it after branching.
> What about applying it now and updating the existing translations as well.
> Since the string was built from existing translation it should be a straight
> forward job (if it is OK, I can do it),  after branching we can make it fuzzy
> so translators can look at.

Please bring this up on gnome-i18n list then to get some feedback from the translation team. Also we'll need to get a string freeze break for this.
Comment 5 Claude Paroz 2009-10-08 07:57:11 UTC
String freeze break approved on gnome-i18n. Go ahead!
Comment 6 Khaled Hosny 2009-10-09 15:30:12 UTC
Created attachment 145138 [details] [review]
New patch

Here is a new patch that addresses the image counter as well. If there is no problem, I can push it to git. The translations are not touched per gnome-l10n discussion.
Comment 7 Felix Riemann 2009-10-09 15:57:53 UTC
Comment on attachment 145138 [details] [review]
New patch

Thanks Khaled for handling this.

Feel free to commit. But please add a translator comment to the counter string, so other translators know what's going on (context would be overkill I guess).
Comment 8 Khaled Hosny 2009-10-09 17:11:13 UTC
(In reply to comment #7)
> (From update of attachment 145138 [details] [review])
> Thanks Khaled for handling this.
> 
> Feel free to commit. But please add a translator comment to the counter string,
> so other translators know what's going on (context would be overkill I guess).

OK, add a translators comment to the counter string too and committed the changes.