After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 596986 - Ambigous dialog buttons when switching account without apply changes before
Ambigous dialog buttons when switching account without apply changes before
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: Accounts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
: 600152 646662 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-10-01 13:48 UTC by Xavier Claessens
Modified: 2018-05-22 13:43 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Xavier Claessens 2009-10-01 13:48:05 UTC
The dialog as 2 buttons: "discard" and "cancel".

1) What's the difference? It's a bit ambigous IMO (maybe not for native English).
2) In French it is translated to "Abandonner" and "Annuler" which is definitely ambigous. Those are 2 stock buttons so we just can't change its translation...
3) What does Cancel button do? close the confirmation dialog and return to unsaved settings? Or cancel the changes made to those settings and actually do the account switch?

I suggest either:

a) Apply/Close: Apply will apply the changes made and switch account. Close will close the dialog and go back to unsaved settings (do not switch account).

b) Apply/Discard:  Apply will apply the changes made and switch account. Discard will drop the unsaved change and switch account.

I prefer solution 'b' but in that case the "cancel" button in the settings widget should also be changed to "discard" I think.
Comment 1 Guillaume Desmottes 2009-10-01 16:05:13 UTC
I agree, current buttons are confusing. Not sure which option I prefer. Any thoughts?
Comment 2 Guillaume Desmottes 2009-11-02 11:08:50 UTC
*** Bug 600152 has been marked as a duplicate of this bug. ***
Comment 3 Xavier Claessens 2009-11-08 11:35:43 UTC
I have another proposal: Having only one "Close" or "OK" button that just hide the dialog and go back editing the account. That force user to click "Cancel" or "Apply" button in the account settings before being able to switch account or close dialog.
Comment 4 Xavier Claessens 2009-11-08 16:12:37 UTC
Branch implementing my last suggestion:

http://git.collabora.co.uk/?p=user/xclaesse/empathy.git;a=shortlog;h=refs/heads/confirmation-account
Comment 5 Guillaume Desmottes 2009-11-10 15:08:58 UTC
I don't know, I think these kind of dialogs are really annoying. What the others people think?
Comment 6 Omer Akram 2010-01-17 12:34:53 UTC
the present form in 2.29.5 i.e cancel/login is simply understandable
Comment 7 Guillaume Desmottes 2010-01-18 10:53:10 UTC
No, this dialog still have "Cancel" and "Discard". Maybe we should disable the treeview while editing as we did when creating a new account to force user to hit the "Cancel" button when he has unsaved changes?
Comment 8 Guillaume Desmottes 2011-04-04 10:04:36 UTC
*** Bug 646662 has been marked as a duplicate of this bug. ***
Comment 9 Guillaume Desmottes 2011-04-04 10:05:12 UTC
From bug #646662:

"""
The dialog informs:
  There are unsaved modifications to your XXX account.
  You are about to select another account, which will discard your changes.

And asks a question:
   Are you sure you want to proceed?

Buttons: Cancel and Discard.

Problems:
- the questions requires a YES/NO answer, buttons indicate some actions
- "cancel" and "discard" have very similar meanings. This creates multiple
problems:
  - non-native English speakers with limited English knowledge won't be able to
easily differentiate between the two
  - some languages (e.g. Romanian) use the same word to translate both words.
  - discard (a button that makes the user loose information) is default




I suggest switching the "Discard" button to "Discard profile changes", and
default button focus to "Cancel".


Also, I believe this violates the HIG (question must be bold and first thing in
the dialog): http://library.gnome.org/devel/hig-book/2.91/windows-
alert.html.en#alerts-confirmation


If indeed the HIG is violated, suggested rewording:

   Are you sure you want to discard changes made to your XXX account?

   You have selected another account. By switching to that account, you will
lose all changes make to your XXX account.

Buttons: Cancel (default focus), Discard profile changes.
"""
Comment 10 Guillaume Desmottes 2011-04-04 10:06:21 UTC
"Discard profile changes" is indeed clearer but probably too long for a button. Would be cool if someone could mail usability@gnome.org to ask UX guys what they think about this issue.
Comment 11 GNOME Infrastructure Team 2018-05-22 13:43:38 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/119.