GNOME Bugzilla – Bug 596985
[dash] Allow clicking on any part of section header to browse
Last modified: 2010-12-04 03:40:28 UTC
This is more intuitive, though we need to make the whole thing feel more like a button.
Created attachment 144499 [details] [review] [dash] Allow clicking on any part of section header to browse
Review of attachment 144499 [details] [review]: I think the behavior is OK as an easter-egg addition, but nobody is going to find it - it's very clear with the dull gray text as opposed to the bright text of More and no prelighting that the header isn't clickable :-) One problem with the code noted below. ::: js/ui/dash.js @@ +526,3 @@ + + _onButtonPress: function() { + this.moreLink.activate(); Chaining this through moreLink, when the moreLink is no longer reactive is a little peculiar. Also, clicking on Places, which doesn't have a moreLink now produces: JS ERROR: !!! message = 'this.moreLink is undefined'
(In reply to comment #2) > Review of attachment 144499 [details] [review]: > > I think the behavior is OK as an easter-egg addition, but nobody is going to > find it - it's very clear with the dull gray text as opposed to the bright text > of More and no prelighting that the header isn't clickable :-) There are some users that try to click on "Application" even though it does not look click able. Maybe we could even get rid of "More" and make the bar highlighted on mouse over (and change the cursor to make it clear that it is click able), that would fix the translation issue for good too.
Created attachment 147885 [details] [review] Updated patch Updated Colin's patch to apply to master and fix the places error.
Review of attachment 147885 [details] [review]: The design is still evolving in this area; talking to mccann a plan is to move the section headers away from feeling like boxes/buttons, and making the clickable area for the expander bigger. But as a shorter term thing I think we can put this in.
Created attachment 149944 [details] [review] Allow clicking on any part of section header to browse No code change since the previous patch, but applies cleanly to master.
Comment on attachment 149944 [details] [review] Allow clicking on any part of section header to browse Attachment 149944 [details] pushed as 6e1a791 - Allow clicking on any part of section header to browse