GNOME Bugzilla – Bug 596831
Add debugging option in custom.conf
Last modified: 2009-11-09 20:21:02 UTC
It is difficult to turn on debugging. Patch attached to add debug/Enable option to custom.conf. Also the slaves are spawned without debugging. This patch passes the --debug flag to the slaves if debug/Enable=true.
Created attachment 144358 [details] [review] Add debug/Enable option to custom.conf, pass --debug to slaves
I think this is a great improvement. However, if you look at the code in gdm/daemon, and grep for the function "is_debug_set", you will notice that there are more places where we really should be checking for whether debug is turned on or not. Wouldn't it be better if all programs just checked the configuration option in the "is_debug_set" function rather than passing the --debug argument around. One exception would be where the daemon launches the simple-greeter, since I am not sure that the GUI login program can easily access the daemon's configuration.
For example, I think it is really important for the session-worker to have its debug turned on when the configuration is set.
Created attachment 147038 [details] [review] updated patch Here is an updated patch that makes all the various GDM programs use the debug/Enable custom.conf key to turn on debug in a consistent way. This patch also removes the --debug argument from the various programs since it never worked right anyway since the argument was never propegated from the main daemon to the programs it launches. This patch also removes the /apps/gdm/simple-greeter/debug GConf setting for the greeter login GUI. It's better for everything to just work with the same debug/Enable flag in custom.conf. This is consistent with how the old GDM worked so it is better for backwards compatibility.
Review of attachment 147038 [details] [review]: Looks good, thanks for doing this.
Fixed in master. I also updated the docs/C/gdm.xml with information about the debug/Enable key and removed reference to the --debug option for the gdm program.