After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 596758 - Configure does not install ipython
Configure does not install ipython
Status: RESOLVED FIXED
Product: accerciser
Classification: Applications
Component: documentation
1.7.x
Other Mac OS
: Normal normal
: ---
Assigned To: Accerciser Developers
Accerciser Developers
Depends on:
Blocks:
 
 
Reported: 2009-09-29 16:27 UTC by Joseph Scheuhammer
Modified: 2020-11-23 22:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch that notifies when ipython is missing (1.85 KB, patch)
2011-06-27 18:02 UTC, Aline Bessa
reviewed Details | Review
corrections in Aline's patch (2.29 KB, patch)
2012-03-01 18:17 UTC, Javier Hernández
none Details | Review

Description Joseph Scheuhammer 2009-09-29 16:27:57 UTC
After configuring, making and installing accerciser, when run, it complains of not finding ipython.
Comment 1 Aline Bessa 2011-06-21 17:16:23 UTC
Bug confirmed.
Comment 2 Aline Bessa 2011-06-27 18:02:36 UTC
Created attachment 190785 [details] [review]
Patch that notifies when ipython is missing

IPython is a dependency of accerciser. You can run it without installing it, but the IPython plugin is *always* compiled. That's why you'll always get a complaint if you don't have this dependency. Since all plugins should be compiled by default, and one can disable any undesired plugin via Accerciser's preferences, I think ./configure *should* alert when IPython is missing. The attached patch does that.
Comment 3 André Klapper 2012-02-26 10:54:14 UTC
ping - can Aline's patch get a review, please?
Comment 4 Joseph Scheuhammer 2012-02-28 15:47:53 UTC
Review of attachment 190785 [details] [review]:

Not a full review, but a note that the patch fails when applying it to the latest master:

> Applying: Adding IPython dependency in configure.in
> error: patch failed: configure.in:8
> error: configure.in: patch does not apply
> Patch failed at 0001 Adding IPython dependency in configure.in

Even though I filed the bug against 1.7.x, this should work with the latest version.

Checking the revision history, the patch does apply up to the ACCERCISER_3_1_5 tag, but doesn't beginning with ACCERCISER_3_1_90.
Comment 5 Javier Hernández 2012-03-01 18:14:40 UTC
Review of attachment 190785 [details] [review]:

Hi!

I applied the patch by hand, and is almost ok.  :)
But, I did some modifications to the proposed patch. 

Actually, we're not using pygtk anymore, so I've removed this related code.

About raising an error if IPython is not available, IMHO, this is not our expected behaviour since Accerciser runs without IPython, so I've turned the AC_MSG_ERROR into a AC_MSG_WARN. Addingly, AFAIK, IPython is not a blessed external dependency, and, since it isn't necessary to get accerciser running, I think we can't make IPython a required dependency. 

Thanks all for your help!

BR
Comment 6 Javier Hernández 2012-03-01 18:17:26 UTC
Created attachment 208800 [details] [review]
corrections in Aline's patch
Comment 7 André Klapper 2012-07-30 13:42:56 UTC
ping - can the patch in comment 6 get in / get a review?

Javier?
Comment 8 Samuel Thibault 2020-11-23 22:52:07 UTC
Applied, thanks!