GNOME Bugzilla – Bug 596758
Configure does not install ipython
Last modified: 2020-11-23 22:52:07 UTC
After configuring, making and installing accerciser, when run, it complains of not finding ipython.
Bug confirmed.
Created attachment 190785 [details] [review] Patch that notifies when ipython is missing IPython is a dependency of accerciser. You can run it without installing it, but the IPython plugin is *always* compiled. That's why you'll always get a complaint if you don't have this dependency. Since all plugins should be compiled by default, and one can disable any undesired plugin via Accerciser's preferences, I think ./configure *should* alert when IPython is missing. The attached patch does that.
ping - can Aline's patch get a review, please?
Review of attachment 190785 [details] [review]: Not a full review, but a note that the patch fails when applying it to the latest master: > Applying: Adding IPython dependency in configure.in > error: patch failed: configure.in:8 > error: configure.in: patch does not apply > Patch failed at 0001 Adding IPython dependency in configure.in Even though I filed the bug against 1.7.x, this should work with the latest version. Checking the revision history, the patch does apply up to the ACCERCISER_3_1_5 tag, but doesn't beginning with ACCERCISER_3_1_90.
Review of attachment 190785 [details] [review]: Hi! I applied the patch by hand, and is almost ok. :) But, I did some modifications to the proposed patch. Actually, we're not using pygtk anymore, so I've removed this related code. About raising an error if IPython is not available, IMHO, this is not our expected behaviour since Accerciser runs without IPython, so I've turned the AC_MSG_ERROR into a AC_MSG_WARN. Addingly, AFAIK, IPython is not a blessed external dependency, and, since it isn't necessary to get accerciser running, I think we can't make IPython a required dependency. Thanks all for your help! BR
Created attachment 208800 [details] [review] corrections in Aline's patch
ping - can the patch in comment 6 get in / get a review? Javier?
Applied, thanks!