After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 596583 - Fix property bindings when using enums
Fix property bindings when using enums
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
2.28.x
Other All
: Normal normal
: ---
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2009-09-28 10:24 UTC by Bastien Nocera
Modified: 2009-10-05 00:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix property bindings when using enums (1.49 KB, patch)
2009-09-28 10:24 UTC, Bastien Nocera 		none Details | Review

Description Bastien Nocera 2009-09-28 10:24:24 UTC 
The enums won't ever get to the G_TYPE_ENUM case because they're
sub-classes of G_TYPE_ENUM. Check whether the value holds an enum
instead and manually check for equality.
Comment 1 Bastien Nocera 2009-09-28 10:24:26 UTC 
Created attachment 144164 [details] [review]
Fix property bindings when using enums
Comment 2 Bastien Nocera 2009-09-28 10:27:16 UTC 
This should fix property application loops in gnome-bluetooth.
Comment 3 Adam Schreiber 2009-10-04 20:29:20 UTC 
This is a gnome-bluetooth patch and not a seahorse patch.  Moving.
Comment 4 Bastien Nocera 2009-10-04 21:05:11 UTC 
Is not, seahorse-bind.c was copied from seahorse into gnome-bluetooth. seahorse-bind.c is broken.
Comment 5 Adam Schreiber 2009-10-04 21:29:20 UTC 
Committed.  Thanks.  What confused me is that we don't have a lib/ in the seahorse tree.
Comment 6 Bastien Nocera 2009-10-04 23:29:05 UTC 
Sorry, should have made a patch against seahorse instead...

A similar work-around could probably be implemented for G_TYPE_FLAGS.
Comment 7 Adam Schreiber 2009-10-04 23:43:17 UTC 
It's ok.  I'll have a look at it.
Comment 8 Adam Schreiber 2009-10-05 00:26:56 UTC 
I just modified the flags case too.