After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 596441 - Remove close animation
Remove close animation
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: gnome-shell-2-28
 
 
Reported: 2009-09-26 16:03 UTC by Owen Taylor
Modified: 2009-09-28 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[windowmanager] Remove destroy effect (2.28 KB, patch)
2009-09-26 21:36 UTC, Dan Winship
committed Details | Review

Description Owen Taylor 2009-09-26 16:03:12 UTC
Having a close animation is sort of nice, since it is explanatory. However:

 - You've already decided you don't want the window any more if you are closing it yourself. So waiting for it to animate can be annoying.

 - CRT are becoming rare so the TV-turning-effect isn't necessarily immediately obvious, and can just be weird.

 - It's a bit ugly because the contents aren't frozen properly and we may see the X server cleaning up the subwindows

 - We have some stacking order issues with the close animations. (The hacks in Mutter may be buggy)

So we should just remove it and make the window immediately vanish.
Comment 1 Dan Winship 2009-09-26 16:17:50 UTC
we don't want a quick fade? also, should the map animation go away too? (or be replaced by a quick fade in)
Comment 2 Dan Winship 2009-09-26 21:36:18 UTC
Created attachment 144088 [details] [review]
[windowmanager] Remove destroy effect

It slows things down, it's a slightly weird effect, and because the
window is still live while it's animating, you may see subwindows
being destroyed during the animation.
Comment 3 Owen Taylor 2009-09-27 12:39:22 UTC
Comment on attachment 144088 [details] [review]
[windowmanager] Remove destroy effect

Patch looks fine. (obviously.) From discussion on Thursday, no we don't want a fade and we're OK with the map animation. [I don't have any particularly theoretical reason why a fade would be weird - but it would share all the other problematical considerations - and probably would look worse than the tv effect if the contents were not frozen properly]
Comment 4 Dan Winship 2009-09-28 13:58:10 UTC
Attachment 144088 [details] pushed as 9432ddb - [windowmanager] Remove destroy effect