GNOME Bugzilla – Bug 596294
Split filter out of chooser
Last modified: 2009-09-25 15:56:43 UTC
I'd like to have the filter part of the chooser split out into a separate widget so that it can be placed independently of the chooser. I've begun work on this, and have some patches towards an initial implementation to attach.
Created attachment 143977 [details] [review] Add seahorse-bind (from Seahorse) for binding GObject properties Hopefully we can remove this once GObject integrates such functionality as tracked in BGO#348080 https://bugzilla.gnome.org/show_bug.cgi?id=348080
Created attachment 143978 [details] [review] Create an external widget for the device filter
Created attachment 143979 [details] [review] Remove filter creation from the BluetoothChooser and use new filter widget
I'm submitting this patch for initial review, it doesn't actually all work together as advertised yet. I'm getting: (lt-test-deviceselection:24590): GLib-GObject-CRITICAL **: g_object_set: assertion `G_IS_OBJECT (object)' failed But thought I might as well let it all get some review while I debug this.
Created attachment 143980 [details] [review] Some filter widget fixes
Created attachment 143997 [details] [review] Create a separate widget for the device filter This widget will be created by the chooser by default but can instead be created as a separate widget and associated with a chooser.
Created attachment 143998 [details] [review] Convert the BluetoothChooser to use BluetoothFilterWidget
Created attachment 144012 [details] [review] Create a separate widget for the device filter This widget will be created by the chooser by default but can instead be created as a separate widget and associated with a chooser.
Attachment 143977 [details] pushed as 5a8246e - Add seahorse-bind (from Seahorse) for binding GObject properties Attachment 143998 [details] pushed as df9e79c - Convert the BluetoothChooser to use BluetoothFilterWidget Attachment 144012 [details] pushed as fd638b1 - Create a separate widget for the device filter