After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 596183 - decodebin2: Rewrite autoplugging and how groups of pads are handled
decodebin2: Rewrite autoplugging and how groups of pads are handled
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.26
Assigned To: Sebastian Dröge (slomo)
GStreamer Maintainers
Depends on:
Blocks: 563828 591677
 
 
Reported: 2009-09-24 12:39 UTC by Sebastian Dröge (slomo)
Modified: 2009-10-07 15:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-decodebin2-Rewrite-autoplugging-and-how-groups-of-pa.patch (82.04 KB, patch)
2009-09-24 12:39 UTC, Sebastian Dröge (slomo)
none Details | Review
0002-uridecodebin-Don-t-post-missing-plugin-messages-twic.patch (1.33 KB, patch)
2009-09-24 14:16 UTC, Sebastian Dröge (slomo)
none Details | Review
0004-decodebin2-Make-sure-that-the-GstDecodePads-are-stil.patch (1.14 KB, patch)
2009-09-24 14:17 UTC, Sebastian Dröge (slomo)
none Details | Review
0004-decodebin2-Make-sure-that-the-GstDecodePads-are-stil.patch (2.53 KB, patch)
2009-09-25 17:26 UTC, Sebastian Dröge (slomo)
none Details | Review
0004-decodebin2-Make-sure-that-the-GstDecodePads-are-stil.patch (2.12 KB, patch)
2009-09-25 17:55 UTC, Sebastian Dröge (slomo)
none Details | Review
0001-decodebin2-Only-use-the-object-lock-for-protecting-t.patch (2.13 KB, patch)
2009-09-26 11:04 UTC, Sebastian Dröge (slomo)
committed Details | Review
0002-decodebin2-Don-t-set-the-external-ghostpads-blocked-.patch (2.77 KB, patch)
2009-09-26 11:05 UTC, Sebastian Dröge (slomo)
committed Details | Review
0003-factorylist-Use-gst_caps_can_intersect-instead-of-_i.patch (1.84 KB, patch)
2009-09-26 11:05 UTC, Sebastian Dröge (slomo)
committed Details | Review
0004-decodebin2-Rewrite-autoplugging-and-how-groups-of-pa.patch (81.21 KB, patch)
2009-09-26 11:06 UTC, Sebastian Dröge (slomo)
committed Details | Review
0005-uridecodebin-Don-t-post-missing-plugin-messages-twic.patch (1.33 KB, patch)
2009-09-26 11:06 UTC, Sebastian Dröge (slomo)
committed Details | Review
0006-decodebin2-Use-the-iterate-internal-links-function-i.patch (2.24 KB, patch)
2009-09-26 11:06 UTC, Sebastian Dröge (slomo)
committed Details | Review
0007-decodebin2-Chains-with-an-exposed-endpad-are-complet.patch (1.79 KB, patch)
2009-09-26 11:07 UTC, Sebastian Dröge (slomo)
committed Details | Review
core-0001-multiqueue-Improve-iterate-internal-links-function.patch (4.12 KB, patch)
2009-09-26 11:07 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2009-09-24 12:39:24 UTC
Created attachment 143906 [details] [review]
0001-decodebin2-Rewrite-autoplugging-and-how-groups-of-pa.patch

Hi,
the attached, large patch rewrites the autoplugging behaviour and how groups of
pads are handled in decodebin2, while keeping backwards compatibility.

Also everything is now documented much better. For reviewing the patch it might
be a good idea to read the general implementation documentation at the top.

PS: Sorry for having such a mega patch, I don't see a way to split it into
several small pieces because I change what a GstDecodeGroup is and this
required code changes *everywhere*
Comment 1 Sebastian Dröge (slomo) 2009-09-24 14:16:14 UTC
Created attachment 143911 [details] [review]
0002-uridecodebin-Don-t-post-missing-plugin-messages-twic.patch

Not strictly necessary but it prevents totem (and friends) from seeing every missing plugin message twice.
Comment 2 Sebastian Dröge (slomo) 2009-09-24 14:17:20 UTC
Created attachment 143912 [details] [review]
0004-decodebin2-Make-sure-that-the-GstDecodePads-are-stil.patch

Not that I could make this a real problem but in theory it could fail in weird situations.

(Note the 0003 patch I have locally is just an unrelated optimization and not needed here)
Comment 3 Sebastian Dröge (slomo) 2009-09-25 17:26:51 UTC
Created attachment 144021 [details] [review]
0004-decodebin2-Make-sure-that-the-GstDecodePads-are-stil.patch
Comment 4 Sebastian Dröge (slomo) 2009-09-25 17:55:28 UTC
Created attachment 144022 [details] [review]
0004-decodebin2-Make-sure-that-the-GstDecodePads-are-stil.patch

Same patch as previous but with corrected indention.

I should've said what has changed before though, this fixes the case when there are still pending blocked pads and decodebin2 is set to READY state again. (Regression introduced in first 0004 patch)
Comment 5 Sebastian Dröge (slomo) 2009-09-26 11:04:18 UTC
Created attachment 144060 [details] [review]
0001-decodebin2-Only-use-the-object-lock-for-protecting-t.patch

New set of patches. Changes:
- two changes that could be split from the mega patch are split now (0001 and 0002)
- minor performance improvement (0003)
- minor fixes/cleanups (0006 and 0007)

For 0006 the core-0001 patch is nice to have.
Comment 6 Sebastian Dröge (slomo) 2009-09-26 11:05:07 UTC
Created attachment 144061 [details] [review]
0002-decodebin2-Don-t-set-the-external-ghostpads-blocked-.patch
Comment 7 Sebastian Dröge (slomo) 2009-09-26 11:05:45 UTC
Created attachment 144062 [details] [review]
0003-factorylist-Use-gst_caps_can_intersect-instead-of-_i.patch
Comment 8 Sebastian Dröge (slomo) 2009-09-26 11:06:10 UTC
Created attachment 144063 [details] [review]
0004-decodebin2-Rewrite-autoplugging-and-how-groups-of-pa.patch
Comment 9 Sebastian Dröge (slomo) 2009-09-26 11:06:34 UTC
Created attachment 144064 [details] [review]
0005-uridecodebin-Don-t-post-missing-plugin-messages-twic.patch
Comment 10 Sebastian Dröge (slomo) 2009-09-26 11:06:54 UTC
Created attachment 144065 [details] [review]
0006-decodebin2-Use-the-iterate-internal-links-function-i.patch
Comment 11 Sebastian Dröge (slomo) 2009-09-26 11:07:20 UTC
Created attachment 144067 [details] [review]
0007-decodebin2-Chains-with-an-exposed-endpad-are-complet.patch
Comment 12 Sebastian Dröge (slomo) 2009-09-26 11:07:46 UTC
Created attachment 144068 [details] [review]
core-0001-multiqueue-Improve-iterate-internal-links-function.patch
Comment 13 Sebastian Dröge (slomo) 2009-10-07 05:32:50 UTC
Comment on attachment 144068 [details] [review]
core-0001-multiqueue-Improve-iterate-internal-links-function.patch

Trivial bits are pushed now
Comment 14 Sebastian Dröge (slomo) 2009-10-07 15:45:56 UTC
Ok, it's all pushed now.