After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 596163 - Doesn't display expected background color in ncurses apps
Doesn't display expected background color in ncurses apps
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.22.x
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-24 08:46 UTC by Raphael Hertzog
Modified: 2009-09-24 21:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot with the problem (119.76 KB, image/png)
2009-09-24 08:49 UTC, Raphael Hertzog
Details
Script recording of bad display in mutt (6.46 KB, application/octet-stream)
2009-09-24 18:34 UTC, Raphael Hertzog
Details

Description Raphael Hertzog 2009-09-24 08:46:31 UTC
Since the upgrade to 0.22.0, gnome-terminal and terminator do not display correctly the wanted background color in mutt (or dselect). Both mutt and dselect use libncursesw5 (5.7+20090803).

Strangely, once a character has been displayed at a given position, it keeps the right background color until the next CTRL+L.

I verified that downgrading to 0.20.5 makes the problem go away. This is all in Debian unstable as of today. Feel free to ask for more info, I can do tests if needed.

Attached is a screenshot so that you understand better what I mean.
Comment 1 Raphael Hertzog 2009-09-24 08:49:07 UTC
Created attachment 143881 [details]
Screenshot with the problem
Comment 2 Tobias Wolf 2009-09-24 16:51:04 UTC
Also affects Vim badly.

Here’s a downstream  bug (but not much info there):
http://bugs.launchpad.net/vte/+bug/434600
Comment 3 Behdad Esfahbod 2009-09-24 17:09:57 UTC
Can someone give me a "script" recording of reproducing this?
Comment 4 Raphael Hertzog 2009-09-24 18:34:00 UTC
Created attachment 143931 [details]
Script recording of bad display in mutt

Please find the requested script output, I just started mutt, switched folder and displayed this bugzilla message.
Comment 5 Behdad Esfahbod 2009-09-24 18:47:52 UTC
Thanks.  Working on a fix.  This is caused by the following comment:

=============
commit 08caf3b174e68ba3d02f04c2595ad552cd50db30
Author: Behdad Esfahbod <behdad@behdad.org>
Date:   Thu Aug 20 23:20:06 2009 -0400

    Remove the fill argument from _vte_new_row_data()
    
    I cannot prove that this change is right, though it looks like it's
    correct!

=============

Well, guess I now know the answer!

Surprised that no one reported this in the weeks that this change was shipped in Fedora.
Comment 6 Behdad Esfahbod 2009-09-24 19:29:58 UTC
Should be fixed in master.   Please test.

commit 58d0affa8eea77353ef47c53923cd82c4203fe1a
Author: Behdad Esfahbod <behdad@behdad.org>
Date:   Thu Sep 24 15:22:30 2009 -0400

    Bug 596163 - Doesn't display expected background color in ncurses apps
    
    Revert semantic change introduced in 08caf3b174e68ba3d02f04c2595ad552cd50db30
Comment 7 Raphael Hertzog 2009-09-24 20:47:35 UTC
Thanks for the quick fix, I tested it and I confirm that it works.
Comment 8 Behdad Esfahbod 2009-09-24 20:48:56 UTC
Thanks!
Comment 9 Tobias Wolf 2009-09-24 21:00:06 UTC
Good job, Behdad.