After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 596157 - Use "Message-ID" instead of "Message-Id"
Use "Message-ID" instead of "Message-Id"
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Mailer
2.28.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2009-09-24 06:44 UTC by Jeremy Visser
Modified: 2009-09-29 20:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Preliminary patch to fix the mentioned bug. (1.88 KB, patch)
2009-09-24 06:44 UTC, Jeremy Visser 		committed Details | Review

Description Jeremy Visser 2009-09-24 06:44:43 UTC 
Created attachment 143871 [details] [review]
Preliminary patch to fix the mentioned bug.

I received a complaint from a USENET user who was reading mail using the
Headliner <http://headliner.sourceforge.net/> news reader. They told me that
threading was breaking because Evolution sends the header "Message-Id", not
"Message-ID".

Reading RFC 5322 <http://tools.ietf.org/html/rfc5322>, it consistently uses the
capitalisation "Message-ID". Handling of headers with differing cases appears
to be undefined in the specification; however, there is at least one known case
where the current behaviour is breaking things.

Along with the old adage "Be conservative with what you emit and be liberal
with what you accept", I have attached a patch to send mail with the Message-ID
header in the correct case.

Before:

  To: jeremy@localhost
  Content-Type: text/plain
  Date: Thu, 24 Sep 2009 00:00:00 +1000
  Message-Id: <censored>

After:

  To: jeremy@localhost
  Content-Type: text/plain
  Date: Thu, 24 Sep 2009 00:00:00 +1000
  Message-ID: <censored>

Please be aware that I am very unfamiliar with Evolution code. While the patch
works as advertised, I am not sure whether it would impact anything else.
Comment 1 Matthew Barnes 2009-09-24 11:44:09 UTC 
Any quality mail or news reader should be doing case-insensitive comparisons of header names, but the RFC grammar does imply they're to be used exactly as printed.

Patch looks correct.  I think there's a couple more cases in Evolution itself, but I'll take care of that.  Thanks for catching that.
Comment 3 Jeremy Visser 2009-09-24 11:59:19 UTC 
Thanks very much. :)

Is there any possibility of this going into 2.28.1?
Comment 4 Matthew Barnes 2009-09-24 12:04:32 UTC 
I'd like to wait a little while just to make sure this doesn't break anything.  Seems straight-forward enough, but you never know.

Ping me again in a week or so and if there haven't been any problems then we can add it for 2.28.1.
Comment 5 Jeremy Visser 2009-09-24 12:06:19 UTC 
Will do.