GNOME Bugzilla – Bug 596101
Debug: gabble logs disappear 5 seconds after disconnection
Last modified: 2009-10-15 15:42:29 UTC
Empathy 2.28.0 I want to see the Gabble logs when I go offline. But the logs disappear before I can read them. How to reproduce: - Be online on Jabber - Open the Debug window in the menu Help->Debug - Select the component Gabble - Go offline - Try to read the Gabble logs (I want to see the disconnection reason) Unless you set GABBLE_PERSIST=1, you have only 5 seconds to read the logs! After that, your logs disappear and the window switches to the empathy logs. I want the Debug window to keep the logs because I need more than 5 seconds to read the logs.
Cosimo has a proposed fix: http://git.collabora.co.uk/?p=user/cosimoc/empathy.git;a=commitdiff;h=2c7f2942cc3ec214a111c0cedae68250b7ce7f95
*** Bug 598559 has been marked as a duplicate of this bug. ***
* Why the move from non g* types? For example: - gint i; + int i; * You could create a function to free the GList of slice-allocated DebugMessage structs and make it be the @value_destroy_func to g_hash_table_new_full(). I guess this would mean you'd have to change how you add a new message as doing _insert with the new beginning of the GList will free the old one. Hmm, you could use _steal. The point is to remove the code duplication in finalize and got_messages_cb. What do you think? * Split these arguments onto new lines: - const gchar *unique_name) + const gchar *name, GtkTreeIter **iter, gboolean use_name) Apart from these minor points, it looks alright. I've not actually tried it yet though. Let me know when you've fixed these.
I updated the branch according to your comments.
Merged to master.