After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 596101 - Debug: gabble logs disappear 5 seconds after disconnection
Debug: gabble logs disappear 5 seconds after disconnection
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
: 598559 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-09-23 18:23 UTC by Alban Crequy
Modified: 2009-10-15 15:42 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Alban Crequy 2009-09-23 18:23:45 UTC
Empathy 2.28.0

I want to see the Gabble logs when I go offline. But the logs disappear before I can read them.

How to reproduce:
 - Be online on Jabber
 - Open the Debug window in the menu Help->Debug
 - Select the component Gabble
 - Go offline
 - Try to read the Gabble logs (I want to see the disconnection reason)

Unless you set GABBLE_PERSIST=1, you have only 5 seconds to read the logs! After that, your logs disappear and the window switches to the empathy logs.

I want the Debug window to keep the logs because I need more than 5 seconds to read the logs.
Comment 2 Jonny Lamb 2009-10-15 14:01:51 UTC
*** Bug 598559 has been marked as a duplicate of this bug. ***
Comment 3 Jonny Lamb 2009-10-15 14:06:26 UTC
 * Why the move from non g* types? For example:

-  gint i;
+  int i;

 * You could create a function to free the GList of slice-allocated DebugMessage structs
   and make it be the @value_destroy_func to g_hash_table_new_full(). I guess this would
   mean you'd have to change how you add a new message as doing _insert with the new
   beginning of the GList will free the old one. Hmm, you could use _steal. The point is to
   remove the code duplication in finalize and got_messages_cb.  What do you think?

 * Split these arguments onto new lines:

-    const gchar *unique_name)
+    const gchar *name, GtkTreeIter **iter, gboolean use_name)

Apart from these minor points, it looks alright. I've not actually tried it yet though. Let me know when you've fixed these.
Comment 4 Cosimo Cecchi 2009-10-15 14:57:28 UTC
I updated the branch according to your comments.
Comment 5 Cosimo Cecchi 2009-10-15 15:42:29 UTC
Merged to master.