GNOME Bugzilla – Bug 596075
Add nautilus-sendto plugin
Last modified: 2009-09-24 14:10:42 UTC
As nautilus-sendto now exports its plugin API.
Created attachment 143788 [details] [review] Add nautilus-sendto plugin
Comment on attachment 143788 [details] [review] Add nautilus-sendto plugin Hi Bastien, thanks for the patch. >+NAUTILUS_SENDTO_REQUIRED=2.28.0 >+ PKG_CHECK_MODULES(NST, >+ [ >+ nautilus-sendto >= $NAUTILUS_SENDTO_REQUIRED >+ ], have_nst="yes", have_nst="no") Shouldn't this be > 2.28.0? It doesn't work with 2.28.0, right? >+INCLUDES = \ >+ -I$(top_srcdir)/libempathy \ >+ -I$(top_builddir) \ >+ -DLOCALEDIR=\""$(datadir)/locale"\" \ >+ $(NST_CFLAGS) \ Where's NST_CFLAGS/NST_LIBS declared? Also, I think you could also include just $(top_srcdir) in the INCLUDES section (removing $(top_srcdir)/libempathy and $(top_builddir) and add libempathy.la as well to libnstempathy_la_LIBADD, like we do for the other submodules (megaphone applet, ...). Finally, do you have other languages with the Empathy plugin strings translated in the n-s-t git tree? If so, it would be great to import those as well.
(In reply to comment #2) > (From update of attachment 143788 [details] [review]) > Hi Bastien, thanks for the patch. > > >+NAUTILUS_SENDTO_REQUIRED=2.28.0 > > >+ PKG_CHECK_MODULES(NST, > >+ [ > >+ nautilus-sendto >= $NAUTILUS_SENDTO_REQUIRED > >+ ], have_nst="yes", have_nst="no") > > Shouldn't this be > 2.28.0? It doesn't work with 2.28.0, right? There's no nautilus-sendto pkg-config file for that version, so it doesn't matter... I'll update the req when I commit (would need to bump it in nautilus-sendto). > >+INCLUDES = \ > >+ -I$(top_srcdir)/libempathy \ > >+ -I$(top_builddir) \ > >+ -DLOCALEDIR=\""$(datadir)/locale"\" \ > >+ $(NST_CFLAGS) \ > > Where's NST_CFLAGS/NST_LIBS declared? the PKG_CHECK_MODULES above does that. > Also, I think you could also include just > $(top_srcdir) in the INCLUDES section (removing $(top_srcdir)/libempathy and > $(top_builddir) and add libempathy.la as well to libnstempathy_la_LIBADD, like > we do for the other submodules (megaphone applet, ...). FWIW, libempathy.la is already dragged in by libempathy-gtk > Finally, do you have other languages with the Empathy plugin strings translated > in the n-s-t git tree? If so, it would be great to import those as well. This should really be in the commit. I'd merge the translations in another commit.
Created attachment 143821 [details] [review] Add nautilus-sendto plugin As nautilus-sendto now exports its plugin API.
I don't understand why you need that: + bindtextdomain (GETTEXT_PACKAGE, LOCALEDIR); + bind_textdomain_codeset (GETTEXT_PACKAGE, "UTF-8"); empathy_gtk_init() calls empathy_init() which does that already. It doesn't work?
Created attachment 143909 [details] [review] Add nautilus-sendto plugin As nautilus-sendto now exports its plugin API.
Attachment 143909 [details] pushed as 0cd0ad2 - Add nautilus-sendto plugin