GNOME Bugzilla – Bug 596027
In Anjal, although invalid mail address warning popup, mail's tab closed automatically
Last modified: 2009-11-05 06:37:40 UTC
This bug is first reported at Moblin Bugzilla: http://bugzilla.moblin.org/show_bug.cgi?id=6108 Build Image(yyyy-mm-dd): git head Bug detailed descriptions(behavior, impact, etc) =========================================================== Write an email with empty (or any invalid) "To:" address, then press "Send" button. Although invalid mail address warning popup, mail's tab closed automatically. User have to rewrite it again. Reproduce Steps(steps,current result, reproduce possibility) =========================================================== (1)Launch Anjal with a valid mail account (2)Write an email with empty "To:" address (3)press "Send" button (4)Although invalid mail address warning popup, mail's tab closed automatically
Created attachment 145107 [details] [review] evolution-patch-bug-596027-dont-close-on-sending-error.patch I've fixed this bug by patching Evolution and Anjal. A new field "sending" is added to the Composer of Evolution to indicate whether the sending is successful or not. Anjal will only emit VIEW_CLOSE signal when the sending was successful. Anjal had a "sending" field in _MailComposerViewPrivate but it didn't work as expected (at least by my understood). Those two patches moved that field to Evolution's Composer. The Composer will set it when the mail passed all checks and is being sent, so Anjal won't have to do those checks again but just need to check the "sending" field. The downside is that two new API functions will have to be added to Evolution to access that "sending" field.
Created attachment 145108 [details] [review] anjal-patch-dont-close-on-sending-error.patch
Yan, I'm sorry, I dont have a build/machine to test this. It may take a week or so to comment back here :(
No problem. I've already put those patches into Moblin for broader testing. The basic idea is that Anjal gets sending result from Evolution's composer and uses that to decide whether to close the composer or not.
Comment on attachment 145108 [details] [review] anjal-patch-dont-close-on-sending-error.patch To anjal-0-1 branch and master.
The patch to Evolution changes API (two new functions in e-msg-composer.h: e_msg_composer_{get,set}_sending()), is this OK for evolution gnome-2-28 branch?
Its ok to add apis to Evolution.
Comment on attachment 145107 [details] [review] evolution-patch-bug-596027-dont-close-on-sending-error.patch Evolution patch committed to master and gnome-2-28.