After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 596003 - Unicode ellipsis in menu
Unicode ellipsis in menu
Status: RESOLVED OBSOLETE
Product: libgoffice
Classification: Other
Component: General
unspecified
Other Linux
: Normal minor
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on: 595615
Blocks: 621639
 
 
Reported: 2009-09-22 19:48 UTC by Bruce Cowan
Modified: 2018-05-22 13:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (9.78 KB, application/octet-stream)
2009-09-22 19:48 UTC, Bruce Cowan
  Details
updated patch after commit (1.36 KB, patch)
2009-09-29 13:56 UTC, Jean Bréfort
none Details | Review

Description Bruce Cowan 2009-09-22 19:48:22 UTC
Created attachment 143747 [details]
Patch

Patch attached.

../goffice/graph/gog-series-prefs.ui.h:2 -
"<i>y'</i>(<i>x</i><sub>first</sub>):"

Translator comment would useful there
Comment 1 Jean Bréfort 2009-09-27 06:37:53 UTC
I'm not sure about all the string changes you propose. I'll fix the trivial ones and leave others unchanged until we decide what's best.
About the missing comment, I'll add it, and may be a tooltip for users.
Comment 2 Jean Bréfort 2009-09-29 13:55:20 UTC
Patch mostly applied. My english is not fluent enough to decide about the two remaining strings:

goffice/app/go-plugin.c:1319
-                            _("Errors occurred while reading plugin informations from file \"%s\"."),
+                            _("Errors occurred while reading plugin information from file \"%s\"."),

goffice/gtk/go-format-sel.ui:436
-                        <property name="label" translatable="yes">_Don't show 1x's</property>
+                        <property name="label" translatable="yes">_Don't show 1xs</property>

Othewise, the requested translator comments have been added as well as appropriate tooltips.
Comment 3 Jean Bréfort 2009-09-29 13:56:25 UTC
Created attachment 144268 [details] [review]
updated patch after commit
Comment 4 Bruce Cowan 2009-09-29 16:48:52 UTC
The first one is (In reply to comment #2)
> goffice/app/go-plugin.c:1319
> -                            _("Errors occurred while reading plugin
> informations from file \"%s\"."),
> +                            _("Errors occurred while reading plugin
> information from file \"%s\"."),

This one is definately right, information is sort of already a plural.

> goffice/gtk/go-format-sel.ui:436
> -                        <property name="label" translatable="yes">_Don't show
> 1x's</property>
> +                        <property name="label" translatable="yes">_Don't show
> 1xs</property>

Yes, I'm not sure about this one. The apostophe should only be there if the bit on the left is a possesive (Sally's fish). If this is a plural, then the apostrophe shouldn't be there (carrots).
Comment 5 Andreas J. Guelzow 2009-09-29 17:14:22 UTC
Jean:
"information" is singular, but in this case it should indeed be "Errors occurred while reading plugin information from file". Using the plural of information would be quite unusual. 

apostrophe s is truely a possessive. Unfortuantely it is frequently abused for plural forms on non-standard words since expressions such as "1xs" look really strange and are difficult to understand. This should probably be reformulated to be more easily understandable. Does this string appear anywhere inside Gnumeric?
Comment 6 Jean Bréfort 2009-09-29 17:54:36 UTC
For the first string, in french, the plural would be quite acceptable, so that I was not sure at all.

About the second, I don't understand what it means exactly. Seems it is not used for now. Seems Emmanuel added that string in 2006.
Comment 7 Morten Welinder 2009-09-29 18:19:55 UTC
I really do not like using a special glyph for ellipsis ("...")

1. Font designers clearly have not put effort into making it look right.

2. We will have a GUI that is using two clearly-different versions.
   The other libraries we link will be using ... for the for the time
   being.
Comment 8 Bruce Cowan 2009-09-29 21:05:48 UTC
CCing the ellipsis fan.
Comment 9 Philip Withnall 2009-09-29 23:11:04 UTC
(In reply to comment #7)
> I really do not like using a special glyph for ellipsis ("...")
> 
> 1. Font designers clearly have not put effort into making it look right.
> 
> 2. We will have a GUI that is using two clearly-different versions.
>    The other libraries we link will be using ... for the for the time
>    being.

The first concern is valid, though on the whole I think the ellipses in modern free fonts are quite good. They're likely to improve if they see increased usage. Looking at all the fonts on my Fedora 11 system, only one (PakTypeTehreer) doesn't have a three-dot ellipsis character, and of the others who do, maybe a third have sub-par glyphs. All the standard fonts (at least Bitstream and DejaVu) have nice ellipsis glyphs.

The second concern is one I share, even though I've been pushing through changes in applications to using single-character ellipses. I hope to make a blog post over the next few days to try and get some discussion going about the issue. For what it's worth, there are bug reports open against GTK+ (bug #595615) and GLib (bug #596060) about using proper ellipses, which you might want to subscribe to.

On a different note, that patch could be improved (the "or not" is completely redundant):

-			_("Wether to add an arrow head atthe end of the line or not"),
+			_("Whether to add an arrow head at the end of the line"),
Comment 10 Jean Bréfort 2009-09-30 04:36:03 UTC
"or not" removed. There might be other such things.
Comment 11 Morten Welinder 2009-09-30 12:55:13 UTC
I just had a look at a few fonts.

Fixed-width fonts do not support ellipsis and other ligatures such as
fi (U-FB00) and ffi (U-FB03).  They may have a glyph in the relevant
position, but the idea that these should take up the same amount of
space as a single letter is preposterous.  Only ligatures that can be
considered independent letters (oe and ae, for example) should be
treated that way.  (That may even be language dependent!)
Comment 12 Morten Welinder 2009-09-30 13:00:23 UTC
Unicode ellipsis backed out.  We can reconsider if gtk+ should switch.
Comment 13 Jean Bréfort 2009-10-02 14:55:00 UTC
the two last strings are now commited. We need to wait until #595615 status changes for ellipses.
Comment 14 Philip Withnall 2012-11-26 09:03:37 UTC
(In reply to comment #12)
> Unicode ellipsis backed out.  We can reconsider if gtk+ should switch.

GTK+ has just switched (commit ceb866dfe6be6d88b8f83a3cbdb8a2a688419c82).
Comment 15 Morten Welinder 2012-11-26 16:08:41 UTC
We might switch when, at run-time, users are considerably more likely to
link against a unicode-ellipsis gtk+ than a tripple-dot gtk+.  Assuming
things look reasonable (visually) at that time.
Comment 16 GNOME Infrastructure Team 2018-05-22 13:03:25 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/goffice/issues/18.