After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595888 - qtdemux plugin should not return value from void function
qtdemux plugin should not return value from void function
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.26
Other Solaris
: Normal normal
: 0.10.17
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-21 23:54 UTC by Brian Cameron
Modified: 2009-09-22 06:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch fixing issue (1.05 KB, patch)
2009-09-21 23:54 UTC, Brian Cameron 		committed Details | Review

Description Brian Cameron 2009-09-21 23:54:13 UTC 
Created attachment 143647 [details] [review]
patch fixing issue

The qtdemux_tag_add_keywords function is a void function, and the compile fails
with the Sun Studio compiler because the function is trying to return a value.
Attached patch fixes this problem.

Can this go upstream?
Comment 1 Sebastian Dröge (slomo) 2009-09-22 06:09:02 UTC 
That's already fixed in GIT by this commit:

commit c469f6b38d289a5c2c2acaf4343223b5b7fa217d
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Thu Aug 13 16:11:59 2009 +0200

    qtdemux: consider 3gpp style tag parsing in some more cases
    
    3GPP specs define a number of tags along with precise layout. While these
    are normally expected to be found in a container whose major brand is a
    3GPP brand, this may also happen when a 3GPP brand is only mentioned as a
    compatible brand.  Apply some checks, heuristic and fallbacks to extract
    such tags as well.