After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595830 - primary should be save option
primary should be save option
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: Gnome-Sound-Recorder
2.27.x
Other Linux
: Normal normal
: ---
Assigned To: gnome media maintainers
gnome media maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-21 12:54 UTC by Oleksij Rempel
Modified: 2010-01-11 23:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make-save-as-default-option.patch (1.77 KB, patch)
2009-09-21 12:54 UTC, Oleksij Rempel 		none Details | Review
Make-save-as-default-option v2 (1004 bytes, patch)
2009-12-20 04:14 UTC, Oleksij Rempel 		none Details | Review

Description Oleksij Rempel 2009-09-21 12:54:11 UTC 
Created attachment 143590 [details] [review]
Make-save-as-default-option.patch

gnome-sound-recorder use default not save option. On the close dialog "Save
recording befor closing?" it use "Close without saving" as default option.
Instead it should "Save As" as default answer.

lsb_release -rd
Description: Ubuntu karmic (development branch)
Release: 9.10

apt-cache policy gnome-media
gnome-media:
  Installiert: 2.27.91-0ubuntu1
  Kandidat: 2.27.91-0ubuntu1
  Versions-Tabelle:
 *** 2.27.91-0ubuntu1 0
        500 http://de.archive.ubuntu.com karmic/main Packages
        100 /var/lib/dpkg/status

https://bugs.launchpad.net/ubuntu/+source/gnome-media/+bug/433207
Comment 1 Sebastien Bacher 2009-12-16 16:14:16 UTC 
the patch has been updated on launchpad, http://launchpadlibrarian.net/36255602/0001-Make-save-as-default-option.patch
Comment 2 William Jon McCann 2009-12-16 16:24:27 UTC 
(In reply to comment #1)
> the patch has been updated on launchpad,
> http://launchpadlibrarian.net/36255602/0001-Make-save-as-default-option.patch

Hi Sebastien,

Please attach patches here directly.  This is especially important now that we have patch review functionality.  And even more so when it obsoletes a patch here.

Thanks
Comment 3 Oleksij Rempel 2009-12-20 04:14:17 UTC 
Created attachment 150095 [details] [review]
Make-save-as-default-option v2

last version of the patch
Comment 4 Marc-Andre Lureau 2010-01-11 23:04:34 UTC 
Committed, please try to respect code style.

commit efcf2f07706d7b76318ab04cc0b5d1018266f822
Author: Alexey Fisher <bug-track@fisher-privat.net>
Date:   Mon Nov 30 12:25:13 2009 +0100

    Bug 595830 - Make "save as" default option
    
    It is better to make "save as" default option to
    prevent any accinedts.
    
    Signed-off-by: Alexey Fisher <bug-track@fisher-privat.net>

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 5 Marc-Andre Lureau 2010-01-11 23:09:45 UTC 
correct commit is d7092d901d5e57f5c0a3829ef9848b022738c4bc