GNOME Bugzilla – Bug 595791
Use accessor functions instead direct access (use GSEAL GnomeGoal)
Last modified: 2010-06-12 22:07:36 UTC
To be ready for GNOME 3 should be able to build with -DGSEAL_ENABLE See http://live.gnome.org/GnomeGoals/UseGseal for more details
Created attachment 143563 [details] [review] Use accessor functions instead direct access GTK+ 2.17.10 is now the required version I've used all the GTK+ 2.17.11 api available, still missing: GTK_WIDGET_REALIZED (GTK_WIDGET ()) GTK_WIDGET_MAPPED (GTK_WIDGET ()) See bug #69872 GTK_ENTRY->im_context See bug #163251 GTK_STATUSBAR->frame GTK_STATUSBAR->label See bug #594535 GTK_MESSAGE_DIALOG->label
(In reply to comment #1) > Created an attachment (id=143563) [details] > Use accessor functions instead direct access > > GTK+ 2.17.10 is now the required version > I've used all the GTK+ 2.17.11 api available, still missing: > > GTK_WIDGET_REALIZED (GTK_WIDGET ()) > GTK_WIDGET_MAPPED (GTK_WIDGET ()) See bug #69872 > > GTK_ENTRY->im_context See bug #163251 > > GTK_STATUSBAR->frame > GTK_STATUSBAR->label See bug #594535 > > GTK_MESSAGE_DIALOG->label Thanks, I have pushed this to master (bumping the dependency to 2.17.11 since that's already released). Keeping this open for the remaining issues.
Created attachment 147609 [details] [review] Use gtk_statusbar_get_message_area() I'm not very sure if this patch exactly substitute the previous behaviour, please test.
Created attachment 153500 [details] [review] Use accessor functions instead direct accessv. Second patch Substitute GTK_WIDGET_MAPPED() and GTK_WIDGET_REALIZED() GTK+ required version bumped to 2.19.5
Created attachment 153501 [details] [review] Use accessor functions instead direct accessv. Second patchv2 Oops, sorry, here the correct patch
Comment on attachment 153501 [details] [review] Use accessor functions instead direct accessv. Second patchv2 Looks good.
Comment on attachment 147609 [details] [review] Use gtk_statusbar_get_message_area() This was already fixed.
Comment on attachment 153501 [details] [review] Use accessor functions instead direct accessv. Second patchv2 commit eb55fc7974c51d26ec5e539d7214787d1fac9a07
Comment on attachment 147609 [details] [review] Use gtk_statusbar_get_message_area() Mark this patch as obsolete
Issue left to fix (before I run into the problem of missing WebKit-1.0.gir here): lib/ephy-gui.c: In function ‘ephy_gui_message_dialog_set_wrap_mode’: ephy-gui.c:518: error: ‘GtkMessageDialog’ has no member named ‘label’ src/bookmarks/ephy-bookmark-action.c: In function ‘entry_key_press_cb’: ephy-bookmark-action.c:418: error: ‘GtkEntry’ has no member named ‘im_context’ src/pdm-dialog.c: In function ‘pdm_dialog_show_clear_all_dialog’: pdm-dialog.c:396: error: ‘GtkMessageDialog’ has no member named ‘label’ pdm-dialog.c:400: error: ‘GtkMessageDialog’ has no member named ‘label’
Created attachment 160677 [details] [review] Do not access im_context GtkEntry element directly This patch soles the "error: ‘GtkEntry’ has no member named ‘im_context’" problem
Can somebody review the last patch please?
Comment on attachment 160677 [details] [review] Do not access im_context GtkEntry element directly ok
Comment on attachment 160677 [details] [review] Do not access im_context GtkEntry element directly commit 685e4e45b4d984d67f93a04701239baddb16ab0d
(In reply to comment #10) > Issue left to fix (before I run into the problem of missing WebKit-1.0.gir > here): > > lib/ephy-gui.c: In function ‘ephy_gui_message_dialog_set_wrap_mode’: > ephy-gui.c:518: error: ‘GtkMessageDialog’ has no member named ‘label’ > > src/bookmarks/ephy-bookmark-action.c: In function ‘entry_key_press_cb’: > ephy-bookmark-action.c:418: error: ‘GtkEntry’ has no member named ‘im_context’ > > src/pdm-dialog.c: In function ‘pdm_dialog_show_clear_all_dialog’: > pdm-dialog.c:396: error: ‘GtkMessageDialog’ has no member named ‘label’ > pdm-dialog.c:400: error: ‘GtkMessageDialog’ has no member named ‘label’ Any idea of what are we supposed to do with the label accesses in GtkMessageDialog?
I hacked my way around this, so we can close the bug since epiphany compiles with GSEAL enabled now.