After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595700 - PNM decoder doesn't handle ASCII encoded pnm data split over several buffers
PNM decoder doesn't handle ASCII encoded pnm data split over several buffers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.15
Assigned To: Sebastian Dröge (slomo)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-19 20:29 UTC by Lutz Mueller
Modified: 2009-09-22 06:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
pnm.diff (5.89 KB, patch)
2009-09-20 08:16 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Lutz Mueller 2009-09-19 20:29:07 UTC
The PNM decoder currently fails if the ASCII encoded PNM data is split over several buffers. The attached patch fixes that and a couple of other problems:
- handle ASCII encoded PNM data split over several buffers
- unref buffers after gst_buffer_span
- fix scanning of header if header data is split over several buffers
Comment 1 Sebastian Dröge (slomo) 2009-09-20 08:16:16 UTC
Created attachment 143507 [details] [review]
pnm.diff

Patch by Lutz for this bug...
Comment 2 Sebastian Dröge (slomo) 2009-09-22 06:14:02 UTC
commit a744f8136b12a879fec4cd554d67f9b4d9cf4069
Author: Lutz Mueller <lutz@topfrose.de>
Date:   Tue Sep 22 08:11:36 2009 +0200

    pnm: Handle ASCII encoded PNM data that is split over multiple buffers
    
    Also:
    - unref buffers after gst_buffer_span
    - fix scanning of header if header data is split over several buffers
    
    Fixes bug #595700.