After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595626 - mySql backend can't have unique Textfield
mySql backend can't have unique Textfield
Status: RESOLVED FIXED
Product: snowy
Classification: Deprecated
Component: general
git master
Other All
: Normal blocker
: 0.2
Assigned To: snowy-maint
snowy-maint
Depends on:
Blocks:
 
 
Reported: 2009-09-18 20:25 UTC by Jesse Mullan
Modified: 2009-09-29 13:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[Note model] Remove uniqueness constraint on title (#595626) (773 bytes, patch)
2009-09-21 14:41 UTC, Sandy Armstrong
committed Details | Review

Description Jesse Mullan 2009-09-18 20:25:24 UTC
See: http://code.djangoproject.com/ticket/2495
Comment 2 Sandy Armstrong 2009-09-21 14:41:02 UTC
Created attachment 143607 [details] [review]
[Note model] Remove uniqueness constraint on title (#595626)

TextFields cannot be unique in MySQL.
Comment 3 Sandy Armstrong 2009-09-21 14:46:37 UTC
Per the mailing list discussion, I don't think we need to verify title uniqueness at the model level.

In fact, it is possible for users to modify their Tomboy note files directly to have identical titles, and in such a situation they would find themselves unable to use Snowy.

I believe we only need to worry about uniqueness when renaming a note, which is a rare operation (especially now, when we don't have note editing enabled), which means it's okay for it to be slow.

The only users who would benefit from us introducing a model-level uniqueness constraint are the same users who find themselves unable to use Snowy in the first place if we have such a constraint.  :-)

I'll probably wait for feedback from Brad (who is out of the country until next week) before I push this, but other comments are welcome.
Comment 4 Brad Taylor 2009-09-29 13:16:57 UTC
Comment on attachment 143607 [details] [review]
[Note model] Remove uniqueness constraint on title (#595626)

Sounds good.  We'll sort out the shrapnel when we implement title editing.