GNOME Bugzilla – Bug 595515
a [GstXSink] base class would be nice
Last modified: 2013-07-17 08:03:46 UTC
Atm. we have three sinks sharing nearly the exact code: ximagesink, xvimagesink and vdpausink. Therefore I think a baseclass that would take care of the common parts (window creation, event handling etc.) would be good to have. The subclass would then implement a draw virtual function where it would put the incoming buffers on the screen. I originally started on this when i wrote the vdpausink, but being lazy and all, I gave it up and took the easy route instead.
Are you going to work on this, or is anybody else?
Is this still needed with the new 1.x meta system ?
Completely independent of the metas IMHO. What is requested here is a base class that does the window creation (not useful, that's only a debugging feature anyway) and all the other X11 handling, like events. I don't think this would be useful after all, as something like vdpausink will probably not only support X11 but also other window systems. And as such can't use this base class anyway. Also the X11 specific code is not really complicated. Let's close this as WONTFIX unless someone really needs it and works on it.