After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595486 - Fix clang bugs
Fix clang bugs
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2009-09-17 16:49 UTC by Bastien Nocera
Modified: 2009-09-19 14:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove unused variable in spinner (888 bytes, patch)
2009-09-17 16:49 UTC, Bastien Nocera 		committed Details | Review
Remove unused variable in bluetooth_client_create_device() (1.88 KB, patch)
2009-09-17 16:49 UTC, Bastien Nocera 		committed Details | Review
Remove unused variable in create_adapter() (1.32 KB, patch)
2009-09-17 16:49 UTC, Bastien Nocera 		committed Details | Review
Move _dump_device() to BluetoothClient (8.28 KB, patch)
2009-09-17 16:49 UTC, Bastien Nocera 		committed Details | Review
Add FIXME in obex_agent_request() (764 bytes, patch)
2009-09-17 16:49 UTC, Bastien Nocera 		committed Details | Review
Remove unused button variable in applet (1.22 KB, patch)
2009-09-17 16:49 UTC, Bastien Nocera 		committed Details | Review
Remove unused variable in device selection test (901 bytes, patch)
2009-09-17 16:50 UTC, Bastien Nocera 		committed Details | Review
Fix invalid memory access in agent.c (825 bytes, patch)
2009-09-17 16:50 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2009-09-17 16:49:35 UTC 
Fix a number of bugs discovered with clang.
Comment 1 Bastien Nocera 2009-09-17 16:49:41 UTC 
Created attachment 143371 [details] [review]
Remove unused variable in spinner
Comment 2 Bastien Nocera 2009-09-17 16:49:44 UTC 
Created attachment 143372 [details] [review]
Remove unused variable in bluetooth_client_create_device()
Comment 3 Bastien Nocera 2009-09-17 16:49:47 UTC 
Created attachment 143373 [details] [review]
Remove unused variable in create_adapter()
Comment 4 Bastien Nocera 2009-09-17 16:49:51 UTC 
Created attachment 143374 [details] [review]
Move _dump_device() to BluetoothClient

and use it in the test-client when a device is selected
Comment 5 Bastien Nocera 2009-09-17 16:49:55 UTC 
Created attachment 143375 [details] [review]
Add FIXME in obex_agent_request()
Comment 6 Bastien Nocera 2009-09-17 16:49:58 UTC 
Created attachment 143376 [details] [review]
Remove unused button variable in applet
Comment 7 Bastien Nocera 2009-09-17 16:50:02 UTC 
Created attachment 143377 [details] [review]
Remove unused variable in device selection test
Comment 8 Bastien Nocera 2009-09-17 16:50:05 UTC 
Created attachment 143378 [details] [review]
Fix invalid memory access in agent.c

Which would happen when long name isn't requested, and there's
no name for the device, just the address.
Comment 9 Bastien Nocera 2009-09-19 14:53:32 UTC 
Attachment 143371 [details] pushed as bf5fb81 - Remove unused variable in spinner
Attachment 143372 [details] pushed as 8bb8f08 - Remove unused variable in bluetooth_client_create_device()
Attachment 143373 [details] pushed as a1c9524 - Remove unused variable in create_adapter()
Attachment 143374 [details] pushed as d272168 - Move _dump_device() to BluetoothClient
Attachment 143375 [details] pushed as 29a077f - Add FIXME in obex_agent_request()
Attachment 143376 [details] pushed as f0d6ac0 - Remove unused button variable in applet
Attachment 143377 [details] pushed as 1bfdfc0 - Remove unused variable in device selection test
Attachment 143378 [details] pushed as 99b975a - Fix invalid memory access in agent.c