After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595445 - Motion notify events are not propagated to parent widget
Motion notify events are not propagated to parent widget
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.20.x
Other Linux
: Normal major
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-17 11:48 UTC by Sayamindu Dasgupta
Modified: 2009-10-24 00:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to return FALSE (596 bytes, patch)
2009-09-17 11:48 UTC, Sayamindu Dasgupta
none Details | Review

Description Sayamindu Dasgupta 2009-09-17 11:48:09 UTC
Created attachment 143333 [details] [review]
Patch to return FALSE

The motion-notify-event handler in VTE returns TRUE, effectively stopping other
handlers to detect pointer motion in the application from being invoked.
Is there any specific reason for returning TRUE ?

More information on how it is affecting Sugar's Terminal activity at
http://bugs.sugarlabs.org/ticket/1309#comment:4
Comment 1 Behdad Esfahbod 2009-09-17 15:49:52 UTC
What do other widgets typically do re propagating motion notify?
Comment 2 Sayamindu Dasgupta 2009-09-17 16:20:17 UTC
(In reply to comment #1)
> What do other widgets typically do re propagating motion notify?

Here's probably a more robust example:

http://git.gnome.org/cgit/totem/tree/src/backend/bacon-video-widget-gst-0.10.c#n798
Comment 4 Behdad Esfahbod 2009-09-21 23:18:04 UTC
ChPe, do you see any issues with this?
Comment 5 Owen Taylor 2009-09-21 23:47:46 UTC
Seems reasonable, though needs to be done early in a development cycle, since any change in event propagation can trigger bugs.

My feeling is that the handler probably should return TRUE while in a drag selection and FALSE otherwise - e.g., if I drag up to the top of the screen while selecting, the full-screen controls shouldn't be shown.
Comment 6 Behdad Esfahbod 2009-10-23 23:04:21 UTC
Sayamindu, want to make an updated patch?
Comment 7 Behdad Esfahbod 2009-10-24 00:14:26 UTC
Ok, I think I fixed it.  Please test with vte master.