GNOME Bugzilla – Bug 595445
Motion notify events are not propagated to parent widget
Last modified: 2009-10-24 00:14:26 UTC
Created attachment 143333 [details] [review] Patch to return FALSE The motion-notify-event handler in VTE returns TRUE, effectively stopping other handlers to detect pointer motion in the application from being invoked. Is there any specific reason for returning TRUE ? More information on how it is affecting Sugar's Terminal activity at http://bugs.sugarlabs.org/ticket/1309#comment:4
What do other widgets typically do re propagating motion notify?
(In reply to comment #1) > What do other widgets typically do re propagating motion notify? Here's probably a more robust example: http://git.gnome.org/cgit/totem/tree/src/backend/bacon-video-widget-gst-0.10.c#n798
More examples: http://google.com/codesearch/p?hl=en&sa=N&cd=16&ct=rc#f2BDHt58KCA/empathy-0.1/libempathy-gtk/gossip-chat-view.c&q=motion-notify-event%20lang:c&l=558 http://google.com/codesearch/p?hl=en&sa=N&cd=32&ct=rc#7q1jEpReeAA/gucharmap/gucharmap-table.c&q=motion-notify-event%20lang:c&l=1369
ChPe, do you see any issues with this?
Seems reasonable, though needs to be done early in a development cycle, since any change in event propagation can trigger bugs. My feeling is that the handler probably should return TRUE while in a drag selection and FALSE otherwise - e.g., if I drag up to the top of the screen while selecting, the full-screen controls shouldn't be shown.
Sayamindu, want to make an updated patch?
Ok, I think I fixed it. Please test with vte master.