After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595401 - gobject assertion and null access to volume instance in playbin
gobject assertion and null access to volume instance in playbin
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-16 20:03 UTC by Josep Torra Valles
Modified: 2009-10-31 13:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to mitigate the issue (925 bytes, patch)
2009-09-16 20:03 UTC, Josep Torra Valles 		committed Details | Review

Description Josep Torra Valles 2009-09-16 20:03:52 UTC 
Created attachment 143298 [details] [review]
patch to mitigate the issue

Playbin keep a pointer to the volume instance instead of a reference to do
volume level and mute.

I've experienced some race related access to the instance after it was
finalized.
Comment 1 Sebastian Dröge (slomo) 2009-09-22 06:34:01 UTC 
Can you provide a sample that exposes this problem? I don't see why anything should go wrong here, playbin always owns a reference (or better the GstBin does) and the volume element is never removed from the bin (only in the final dispose).

(Apart from that you should really use playbin2 ;) )
Comment 2 Sebastian Dröge (slomo) 2009-09-22 08:31:25 UTC 
Ok, after discussing on IRC I'm going to push this after 0.10.25 release. That code is still a bit fishy but this is playbin1 and in playbin2 it's all fixed and better ;)
Comment 3 Tim-Philipp Müller 2009-10-31 13:00:14 UTC 
> Ok, after discussing on IRC I'm going to push this after 0.10.25 release

Could do that now if the patch is still needed..
Comment 4 Sebastian Dröge (slomo) 2009-10-31 13:04:25 UTC 
commit 5cd9c08cf60f6e0d1e2e6895e3dde28556d205f9
Author: Josep Torra Valles <n770galaxy@gmail.com>
Date:   Sat Oct 31 14:02:40 2009 +0100

    playbin: Make sure to keep a reference on the volume element
    
    Fixes null pointer dereferences under certain circumstances.
    
    Fixes bug #595401.