After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595342 - braseromedia fails because threads aren't initialized
braseromedia fails because threads aren't initialized
Status: RESOLVED FIXED
Product: gnome-python-desktop
Classification: Deprecated
Component: general
2.27.x
Other Linux
: Normal major
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-16 11:00 UTC by Emilio Pozuelo Monfort
Modified: 2009-12-05 18:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch by Andrew Price to initialize threads (343 bytes, patch)
2009-09-16 11:01 UTC, Emilio Pozuelo Monfort
none Details | Review

Description Emilio Pozuelo Monfort 2009-09-16 11:00:13 UTC
[ still no brasero component :) ]

[ From http://bugs.debian.org/546668 ]

It seems braseromedia uses threads, but doesn't call pyg_enable_threads(), which makes it fail in some scenarios.

It works for me, but the OP in the Debian has the issue. I asked Frederic Peters and he said it looks like the right fix.

There's a patch by Andrew Price at http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=20;filename=pyg_enable_threads.diff;att=1;bug=546668

Looks like we need a hard code freeze exception now.
Comment 1 Emilio Pozuelo Monfort 2009-09-16 11:01:16 UTC
Created attachment 143264 [details] [review]
Patch by Andrew Price to initialize threads
Comment 2 Emilio Pozuelo Monfort 2009-09-16 11:05:42 UTC
Or perhaps the g_thread_init() call in this commit will fix it, I dunno.

http://git.gnome.org/cgit/brasero/commit/?id=ead7ab5395f43273a58770493b5bf47659cce4fc
Comment 3 Gustavo Carneiro 2009-09-16 13:00:54 UTC
This is not a critical bug IMHO; it can be worked around in Python code by calling gobject.threads_init() before importing the brasero module.  Right?
Comment 4 Emilio Pozuelo Monfort 2009-09-16 15:14:51 UTC
(In reply to comment #3)
> This is not a critical bug IMHO; it can be worked around in Python code by
> calling gobject.threads_init() before importing the brasero module.  Right?

Yes, that works. Does that mean you will add the attached patch in a later release and not now because there's a workaround and we're at hard code freeze, or that you won't commit it at all? If the latter, the example needs to be fixed.
Comment 5 Gustavo Carneiro 2009-09-17 10:32:36 UTC
Of course this needs to be fixed later.  Just, since there's a simple workaround it's not worth asking for code freeze break.  In the mean time I added the workaround to the example.
Comment 6 Gustavo Carneiro 2009-12-05 18:19:19 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.