After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595341 - No option to get back icons in dialog action buttons
No option to get back icons in dialog action buttons
Status: RESOLVED WONTFIX
Product: gnome-control-center
Classification: Core
Component: [obsolete] Appearance
2.27.x
Other Linux
: Immediate blocker
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-16 10:21 UTC by Xavier Claessens
Modified: 2010-09-22 15:29 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Xavier Claessens 2009-09-16 10:21:24 UTC
The default changed to not have icons in dialog action buttons. I think at very least we should have a checkbox in the interface tab to change that.

The gconf key is /desktop/gnome/interface/buttons_have_icon.

I make this bug blocker because GNOME 2.28.0 can't be released without either reverting to old behaviour (showing icon by default) or at least make it configurable.
Comment 1 Guillaume Desmottes 2009-09-16 10:25:47 UTC
I agree. As I said on bug #592756, making a such big UI change without giving to users the tool to revert it is none sense.
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2009-09-16 10:33:36 UTC
I also agree that changing the look and removing the interface preference tab at the same time is a bad idea. I stil haven't seen any research (or even a poll) that hints that removing the icons is what users would prefer, but I feel that the responsible persons don't want to roll that back. So *please* lets keep the UI for now.
Comment 3 Patryk Zawadzki 2009-09-16 10:36:22 UTC
If we really want to remove icons, we should make it in the application sources. There are places where icons make a lot of sense (Add/Remove icons for example) and places where icons should also be dropped from select boxes etc. for consistency.
Comment 4 Claude Paroz 2009-09-16 11:49:38 UTC
Is there at least a Wiki page where the rationale behind this controversial decision is presented?
Comment 5 Matthias Clasen 2009-09-16 12:24:30 UTC
> I make this bug blocker because GNOME 2.28.0 can't be released without either
> reverting to old behaviour (showing icon by default) or at least make it
> configurable.

"I don't like it" is not a blocker criterium.

> I also agree that changing the look and removing the interface preference tab
> at the same time is a bad idea. 

Nice strawman, but the interface tab has not been removed, as far as I can see. We did remove it in Fedora, but that patch has not been merged upstream.
Comment 6 Xavier Claessens 2009-09-16 12:29:43 UTC
(In reply to comment #5)
> "I don't like it" is not a blocker criterium.

This bug is not about that, but about making it configurable in UI. That issue is blocker.

(In reply to comment #2)
> I also agree that changing the look and removing the interface preference tab
> at the same time is a bad idea.

That tab is not going to be removed. There is bug #592756 for that.
Comment 7 Greg K Nicholson 2009-09-16 20:24:24 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > "I don't like it" is not a blocker criterium.

Criterion. :)

> This bug is not about that, but about making it configurable in UI. That issue
> is blocker.

Icons being absent from text-labelled buttons isn't blocker-level severe, especially since it was an intentional change. Gnome 2.28 would still be functional on a day-to-day basis without this bug being fixed. (Arguably less or more functional, but still functional.)

Adding a UI preference may seem like the easy option but it's actually costly in the long run. First of all it doubles the number of supported codepaths that need testing.

If UI designers aren't strict about which options warrant preferences in the UI, the preferences dialogue quickly becomes unwieldy. Mozilla (SeaMonkey) and KDE both went down this route and now have positively labyrinthine prefs, which a large majority of of users find very confusing.

So this is why the devs might be reticent to having a UI pref. The correct approach is to make a design decision, and allow the relatively-few users who care enough to use gconf-editor.
Comment 8 Patryk Zawadzki 2009-09-16 21:17:26 UTC
Greg:

That's why I advocate going through dialogs one by one, each time making sure what remains is both elegant and usable rather than doing this globally. I do understand the reasons behind this change, I just don't like the pace.
Comment 9 Michael Monreal 2009-09-17 07:20:57 UTC
Patryk, as a _design decision_, as Greg already said, this is just the easiest approach. How long would you think it would take to "go[ing] through dialogs one by one"? Even then there would be a good chance of 3rd party apps not following the guidelines etc. The current design is very easy to implement (no work required by app developers) and has a very high consistency. Sure there are some places that need(ed) to be fixed (mostly for menus) but that's less work by far. That said, I have been VERY against this default change but after forcing myself to use it for a while I totally love it.
Comment 10 Patryk Zawadzki 2009-09-17 07:57:39 UTC
Michael:

I am using it since day one it was proposed but I still consider the "open"/"save as" dialog's add/remove buttons weird at least. Ditto for dialogs with >2 buttons (mostly "save changes?").
Comment 11 Xavier Claessens 2009-09-17 08:42:53 UTC
I find it particulary annoying for Close/Cancel/Save dialogs when you close unsaved work. Without icons on buttons it takes much more time to find the right one. I'm sure lots of user will lose their work because of that...
Comment 12 Eric Piel 2009-09-21 13:16:41 UTC
Maybe in the GUI, the options to have icons in the menu and in the button could be merged into a "Show icons in menus and buttons" check-box. Most users will want to activate icons for both of for none. So it provides a good trade-off between not adding more preferences and still allowing to reactivate the icons in the buttons without gconf-editor hunting skills.

In case the two options would not be synchronized (because they were tweaked through gconf), the check-box would display a "half check" state, working similarly to the execution rights check-box in the file properties of nautilus.
Comment 13 Xavier Claessens 2009-09-21 13:35:08 UTC
That's a good idea.
Comment 14 Mantas Kriaučiūnas 2010-03-01 15:27:06 UTC
Are there any option to turn on icons on buttons in GNOME 2.30 ?
Comment 15 Bastien Nocera 2010-09-22 15:29:30 UTC
(In reply to comment #14)
> Are there any option to turn on icons on buttons in GNOME 2.30 ?

See comment 0...

For GNOME 3.x, this option won't be available. If you want to have it available in GNOME Plumbing, talk to vuntz about kickstarting the project.