After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595337 - Can not input with keyboard 'Space' button in Calculator
Can not input with keyboard 'Space' button in Calculator
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
5.27.x
Other All
: Urgent critical
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-16 08:39 UTC by XuJin
Modified: 2009-09-17 23:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Allows space to work on buttons (1.46 KB, patch)
2009-09-17 02:24 UTC, Robert Ancell
committed Details | Review

Description XuJin 2009-09-16 08:39:05 UTC
1. launch Calculator
2. move focus to the button on the Calculator panel
3. press 'Space' button 
4, the button being focused can not be input into the Calculator

This bug can be both reproduced in Linux and Solaris.
Comment 1 Tim Miao 2009-09-17 02:18:45 UTC
This bug blocks keyboard accessing for accessibility users. I'd like to confirm this bug cause it can be reproduced on both linux and OpenSolaris with latest GNOME release.
Comment 2 Robert Ancell 2009-09-17 02:24:32 UTC
Created attachment 143315 [details] [review]
Allows space to work on buttons

I think this needs a freeze break:
http://live.gnome.org/ReleasePlanning/Freezes
Comment 3 Robert Ancell 2009-09-17 02:51:27 UTC
Freeze break requested:
"Hi,

A bug [1] has been reported against gcalctool 5.27.92 showing that keyboard accessibility does not work.  This is a regression from previous stable gcalctool releases.

The attached patch fixes this problem by stopping the keyboard event for spacebar from being consumed when the buttons are in focus.  I am the maintainer of gcalctool and I approve this patch.

[1] https://bugzilla.gnome.org/show_bug.cgi?id=595337

Thanks,
--Robert Ancell
GCalctool Maintainer"
Comment 4 Robert Ancell 2009-09-17 23:16:53 UTC
Fixed for 2.28.0:
http://git.gnome.org/cgit/gcalctool/commit/?id=2f82c88b4da54c0176447b921c352892cd56d8cc
Don't override space bar when buttons are focussed as this stops keyboard control (Robert Ancell, Bug #595337) (Hard code freeze break approved by Andre Klapper and Frederic Peters)