After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595296 - No visible focus indication for ListView
No visible focus indication for ListView
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
git master
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-15 17:26 UTC by Eitan Isaacson
Modified: 2009-11-12 04:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Tweak theming of ListView depending on focus location. (5.77 KB, patch)
2009-09-30 18:41 UTC, Eitan Isaacson 		none Details | Review
Change focus theming depending on header focus. (2.48 KB, patch)
2009-09-30 18:44 UTC, Eitan Isaacson 		none Details | Review
Change ListView selection color depending on focus location. (5.99 KB, patch)
2009-10-02 00:11 UTC, Eitan Isaacson 		none Details | Review
Make border bolder when in focus. (4.86 KB, patch)
2009-10-02 00:12 UTC, Eitan Isaacson 		none Details | Review
Change ListView selection color depending on focus location. (5.94 KB, patch)
2009-10-02 00:18 UTC, Eitan Isaacson 		none Details | Review
Make border bolder when in focus. (3.34 KB, patch)
2009-10-02 01:49 UTC, Eitan Isaacson 		none Details | Review

Description Eitan Isaacson 2009-09-15 17:26:44 UTC 
There seems to be no way of knowing that a ListView is in Focus in Banshee. This is important for keyboard users.
Comment 1 Eitan Isaacson 2009-09-25 19:34:50 UTC 
This is also addressed in the keyboard navigation branch[1]. I just changed the shading a bit, it is probably not enough. I wish someone with visual talents gave this some love.

1. http://github.com/eeejay/banshee-a11y/tree/keyboard_control
Comment 2 Gabriel Burt 2009-09-26 18:26:07 UTC 
CC'ing such a person :)
Comment 3 Eitan Isaacson 2009-09-30 18:41:20 UTC 
Created attachment 144432 [details] [review]
Tweak theming of ListView depending on focus location.
Comment 4 Eitan Isaacson 2009-09-30 18:44:14 UTC 
Created attachment 144434 [details] [review]
Change focus theming depending on header focus.
Comment 5 Eitan Isaacson 2009-09-30 18:45:41 UTC 
The last patch is dependent on the patch set in bug #595299.
Comment 6 Eitan Isaacson 2009-10-02 00:11:31 UTC 
Created attachment 144555 [details] [review]
Change ListView selection color depending on focus location.

This depends on the patch set in bug #595300.
Comment 7 Eitan Isaacson 2009-10-02 00:12:17 UTC 
Oops, I mean bug #595299.
Comment 8 Eitan Isaacson 2009-10-02 00:12:47 UTC 
Created attachment 144556 [details] [review]
Make border bolder when in focus.
Comment 9 Eitan Isaacson 2009-10-02 00:18:30 UTC 
Created attachment 144557 [details] [review]
Change ListView selection color depending on focus location.

This applies to trunk, no need for other patches. Use the patch above if you want to see it work with header control.
Comment 10 Eitan Isaacson 2009-10-02 01:49:05 UTC 
Created attachment 144562 [details] [review]
Make border bolder when in focus.

Removed the RoundedFrame/SourceView stuff. It was CPU intensive and silly. 
Redrawing a NoWindow parent on focus change is tricky...
Sorry about the spam.
Comment 11 Gabriel Burt 2009-10-27 20:18:03 UTC 
Bulk changing the assignee to banshee-maint@gnome.bugs to make it easier for people to get updated on all banshee bugs by following that address.  It's usually quite apparent who is working on a given bug by the comments and/or patches attached.
Comment 12 Eitan Isaacson 2009-10-27 20:23:00 UTC 
I am done working on this. Would love to see it in trunk.