After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595294 - No alternative text exposed in AT-SPI for playback buttons
No alternative text exposed in AT-SPI for playback buttons
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
git master
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-15 17:14 UTC by Eitan Isaacson
Modified: 2009-11-12 04:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed workaround (1.91 KB, patch)
2009-09-15 17:14 UTC, Eitan Isaacson 		committed Details | Review

Description Eitan Isaacson 2009-09-15 17:14:58 UTC 
Created attachment 143237 [details] [review]
Proposed workaround

When viewing the top playback buttons in Accerciser, the button names like
"Play" are not exposed, neither is their tooltip in the accessible's
description. 
I believe this is mostly a GAIL issue, but it can be worked around for now in
Banshee.
Comment 1 Eitan Isaacson 2009-09-25 19:25:36 UTC 
This is patch is ready for trunk, please review!
Comment 2 Gabriel Burt 2009-09-26 18:42:19 UTC 
This patch works and all, but I don't understand why there is a problem here - we have textual Names and Descriptions for these actions (from which the Button widget proxies are created) - why aren't they used?

The reason I ask is that we have many other button/actions that don't have a stock equivalent and that we need a different fix for.
Comment 3 Gabriel Burt 2009-09-26 18:47:46 UTC 
Comment on attachment 143237 [details] [review]
Proposed workaround

I've committed this patch as the proposed workaround it is.  Thanks, Eitan.
Comment 4 Eitan Isaacson 2009-09-30 18:51:22 UTC 
(In reply to comment #2)
> This patch works and all, but I don't understand why there is a problem here -
> we have textual Names and Descriptions for these actions (from which the Button
> widget proxies are created) - why aren't they used?
> 

This is a GAIL issue, I will fix it when I have the time. Hopefully soon.
Comment 5 Eitan Isaacson 2009-10-06 19:32:32 UTC 
I submitted a gtk+ patch for review that should resolve this issue in the correct manner: bug #597596.
Comment 6 Gabriel Burt 2009-11-12 04:04:55 UTC 
Awesome work on this Eitan, thanks!