After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595265 - SDES handling in RTPSource
SDES handling in RTPSource
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-15 12:19 UTC by Pascal Bühler
Modified: 2009-12-22 20:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (17.72 KB, patch)
2009-09-15 12:19 UTC, Pascal Bühler 		none Details | Review

Description Pascal Bühler 2009-09-15 12:19:04 UTC 
Created attachment 143226 [details] [review]
patch

Use a structure to contain SDES info inside of RTPSource.
This allows multiple PRIV SDES key/values pairs.
All SDES values set on the source are sent in the RTCP message, if there is a
privacy concern then it is the respocibility of the user of RTPSession to
remove those values from SDES.
Comment 1 Wim Taymans 2009-12-22 20:46:55 UTC 
Commited with some changes and cleanups and extra checks. Also moved the type to name conversion functions to -base.

commit c3448f978e16e29cc92133edcaea2c9285d35277
Author: Pascal Buhler <pascal.buhler@tandberg.com>
Date:   Mon Aug 31 18:42:25 2009 +0200

    rtpmanager: improve SDES handling
    
    Store SDES internally as a struct to support multiple PRIV values.
    Include all values set in SDES struct when sending RTCP SDES.