After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595245 - Docbook processing instruction (PI) should not be marked for translation
Docbook processing instruction (PI) should not be marked for translation
Status: RESOLVED WONTFIX
Product: gnome-doc-utils
Classification: Deprecated
Component: xml2po
CVS HEAD
Other Linux
: Normal normal
: ---
Assigned To: gnome-doc-utils maintainers
Danilo Segan
gnome[unmaintained]
Depends on: 597216
Blocks:
 
 
Reported: 2009-09-15 08:08 UTC by Yasushi SHOJI
Modified: 2020-03-03 18:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Small sample source file (454 bytes, text/xml)
2009-09-15 08:08 UTC, Yasushi SHOJI
Details
a pot file generated from the current xml2po on sample.xml (726 bytes, text/plain)
2009-09-15 08:10 UTC, Yasushi SHOJI
Details

Description Yasushi SHOJI 2009-09-15 08:08:46 UTC
Created attachment 143213 [details]
Small sample source file

I just started to use docbook processing instruction (PI) in our data
sets. Running current xml2po on our data set shows that it picks up PI
along with translatable string.

On gnome-doc-devel-list, a few other people agreed on that "PIs should
absolutely not be marked for translation."

http://thread.gmane.org/gmane.comp.gnome.documentation.devel/459

to find out where, I dug a bit. I run xml2po on attached sample code
with enabling a debug code at the top of XMLDocument::normalizeNode()
in xml2po/__init__.py, I got:

> > <norm> (element) [<norm>PI Test</norm>]
> > <text> (text) [PI Test]
> > <norm> (element) [<norm>Section Title</norm>]
> > <text> (text) [Section Title]
> > <norm> (element) [<norm>sample table</norm>]
> > <text> (text) [sample table]
> > <norm> (element) [<norm><?dbfo bgcolor="#000000" ?>Translatable String</norm>]
> > <dbfo> (pi) [<?dbfo bgcolor="#000000" ?>]
> > <text> (text) [Translatable String]

it seems to me that normalized node with PI is judged
"worthOutputting".  Is it right to assume that
XMLDocument::worthOutputting() is the place to modify and make it to
return false if element has PI?
Comment 1 Yasushi SHOJI 2009-09-15 08:10:09 UTC
Created attachment 143214 [details]
a pot file generated from the current xml2po on sample.xml
Comment 2 Claude Paroz 2009-10-03 16:22:28 UTC
Note that the proposed patch in bug #597216 resolves this issue and adds a PI to regression tests.
Comment 3 André Klapper 2020-03-03 18:36:46 UTC
gnome-doc-utils has been superseded by yelp-xsl, yelp-tools, and itstool.

gnome-doc-utils will not see any further development, hence closing as WONTFIX.

See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/255