After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595027 - autorun.inf icon parsing is too strict
autorun.inf icon parsing is too strict
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2009-09-12 21:44 UTC by timeless
Modified: 2013-11-01 10:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (574 bytes, patch)
2009-09-12 21:44 UTC, timeless 		none Details | Review

Description timeless 2009-09-12 21:44:38 UTC 
Created attachment 143085 [details] [review]
patch

it's possible that a hardware product will be shipping with an autorun.inf
whose contents is approximately:

[autorun]
icon = icon.ico

this works fine on Windows, sadly it doesn't work with gvfs because the regexp
introduced by bug 154549 is too strict.

I am going to try to fix the autorun.inf file to not include spaces, however
it's possible that i missed the flash freeze. And as this is a perfectly valid
file, it's quite likely there are other such files in the while for other
products.
Comment 1 Felix Möller 2012-08-01 22:26:40 UTC 
Thanks for your patch!

Looking at the source this patch is still valid. I do not have an autorun.inf file at my hands right now, however looking at the inf defintion at http://technet.microsoft.com/en-us/library/dd346952.aspx there are many times spaces around the "=" thus I think this is very reasonable.

Could somebody apply, it is just a single line..
Comment 2 Ross Lagerwall 2013-11-01 10:06:33 UTC 
Pushed to master with tweaks as 0f5d4be. Thanks!