After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594962 - No accessor for GTK_ENTRY (entry)->editing_canceled
No accessor for GTK_ENTRY (entry)->editing_canceled
Product: gtk+
Classification: Platform
Component: Widget: GtkEntry
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
Depends on:
Blocks: 594957 597610 599213
Reported: 2009-09-12 03:02 UTC by Javier Jardón (IRC: jjardon)
Modified: 2009-10-21 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Proposed patch (7.97 KB, patch)
2009-09-17 03:08 UTC, Cody Russell
committed Details | Review

Description Javier Jardón (IRC: jjardon) 2009-09-12 03:02:58 UTC
As discussed in IRC:

<mclasen> jjardon: editing_canceled should really have been a parameter of the GtkCellEditable::editing-done signal
<mclasen> if we need api for it, it should probably be a property on the cell editable interface
Comment 1 Cody Russell 2009-09-17 03:08:12 UTC
Created attachment 143316 [details] [review]
Proposed patch
Comment 2 Matthias Clasen 2009-09-18 21:22:56 UTC
Comment on attachment 143316 [details] [review]
Proposed patch

Looks ok for 2.19. Of course, when this lands, we should also make the code that currently uses entry->editing_canceled directly go through the property.
Comment 3 Javier Jardón (IRC: jjardon) 2009-10-21 16:58:32 UTC
Comment on attachment 143316 [details] [review]
Proposed patch

commit 0f33ad4ee1211fcaac13ca74ed372b74116d98d5