Bug 594908 – empathy crashed with SIGSEGV in tp_contact_list_got_added_members_cb()

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 594908 - empathy crashed with SIGSEGV in tp_contact_list_got_added_members_cb()


Summary:	empathy crashed with SIGSEGV in tp_contact_list_got_added_members_cb()


Status:	RESOLVED FIXED

Product:	empathy
Classification:	Core
Component:	Contact List
Version:	2.27.x
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	empathy-maint
QA Contact:

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-09-11 16:29 UTC by Sebastien Bacher
Modified:	2009-10-14 16:13 UTC

See Also:
GNOME target:	2.28.x
GNOME version:	---

Description Sebastien Bacher 2009-09-11 16:29:24 UTC

The bug has been opened on https://bugs.launchpad.net/bugs/427684

"Crash on startup, looks like it's trying to connect.

empathy 2.27.92-0ubuntu2

+ Trace 217499

#0 tp_contact_list_got_added_members_cb
at empathy-tp-contact-list.c line 361
#1 get_contacts_by_handle_cb
at empathy-tp-contact-factory.c line 1028
#2 contacts_context_continue
at contact.c line 963
#3 contacts_context_continue
at contact.c line 988
#4 contacts_context_continue
at contact.c line 988
#5 contacts_got_attributes
at contact.c line 1768
#6 connection_got_contact_attributes
at connection-handles.c line 728
#7 _tp_cli_connection_interface_contacts_invoke_callback_get_contact_attributes
at _gen/tp-cli-connection-body.h line 7950
#8 tp_proxy_pending_call_idle_invoke
at proxy-methods.c line 153
#9 g_idle_dispatch
at /build/buildd/glib2.0-2.21.6/glib/gmain.c line 4065
#10 IA__g_main_context_dispatch
at /build/buildd/glib2.0-2.21.6/glib/gmain.c line 1960
#11 g_main_context_iterate
at /build/buildd/glib2.0-2.21.6/glib/gmain.c line 2591
#12 IA__g_main_loop_run
at /build/buildd/glib2.0-2.21.6/glib/gmain.c line 2799
#13 tp_cli_connection_interface_avatars_run_get_known_avatar_tokens
at _gen/tp-cli-connection-body.h line 6105
#14 dup_contact_for_tp_contact
at empathy-tp-contact-factory.c line 781
#15 contacts_array_new
at empathy-tp-contact-factory.c line 870
#16 get_contacts_by_handle_cb
at empathy-tp-contact-factory.c line 1025
#17 contacts_context_continue
at contact.c line 963
#18 contacts_context_continue
at contact.c line 988
#19 contacts_context_continue
at contact.c line 988
#20 contacts_got_attributes
at contact.c line 1768
#21 connection_got_contact_attributes
at connection-handles.c line 728
#22 _tp_cli_connection_interface_contacts_invoke_callback_get_contact_attributes
at _gen/tp-cli-connection-body.h line 7950
#23 tp_proxy_pending_call_idle_invoke
at proxy-methods.c line 153
#24 g_idle_dispatch
at /build/buildd/glib2.0-2.21.6/glib/gmain.c line 4065
#25 IA__g_main_context_dispatch
at /build/buildd/glib2.0-2.21.6/glib/gmain.c line 1960
#26 g_main_context_iterate
at /build/buildd/glib2.0-2.21.6/glib/gmain.c line 2591

Comment 1 Guillaume Desmottes 2009-09-14 14:06:44 UTC

Looking at the trace, EmpathyTpContactListPriv seems to be wrong. One explanation could be that the callback has been called after the TpContactList has been disposed; but that shouldn't happen as the contact list is passed as a weak object to tp_connection_get_contacts_by_handle.
Any chance you could reproduce this crash with logs? (EMPATHY_DEBUG=all)

A memory corruption could be another explanation, in which case we'll need valgrind logs.

Comment 2 Cosimo Cecchi 2009-09-17 13:13:07 UTC

This has probably been fixed in master with http://git.gnome.org/cgit/empathy/commit/?id=7eb816f6c5ce610f767a40f387f0b4aef2a6e153

Closing as such, feel free to reopen if you can still reproduce the bug.

Comment 3 Sebastien Bacher 2009-10-14 13:51:04 UTC

There is a similar crash on https://bugs.edge.launchpad.net/ubuntu/+source/empathy/+bug/446259 with 2.28.0.1

Comment 4 Cosimo Cecchi 2009-10-14 14:27:03 UTC

Yes, that commit has not been backported to the gnome-2-28 branch.
Don't know if we should...Guillame?

Comment 5 Guillaume Desmottes 2009-10-14 15:02:58 UTC

I don't know this code well enough to judge if this patch is safe enough or not.

Xavier, Will: what do you think?

Comment 6 Xavier Claessens 2009-10-14 16:13:30 UTC

I'm fine to backport to 2.28