After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594701 - Don't update the LastPlayed stamp when adding songs to the play queue
Don't update the LastPlayed stamp when adding songs to the play queue
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: 1.x
Assigned To: Alexander Kojevnikov
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-10 02:07 UTC by Alexander Kojevnikov
Modified: 2009-10-27 20:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (37.13 KB, patch)
2009-10-15 21:39 UTC, Gabriel Burt 		committed Details | Review
A small fix (2.67 KB, patch)
2009-10-15 23:50 UTC, Alexander Kojevnikov 		committed Details | Review

Description Alexander Kojevnikov 2009-09-10 02:07:40 UTC 
See comments 33-34 in bug 565767

Fix suggested by Gabriel:

> Alex, what do you think about creating a new table PlayQueueShuffle or
> something w/ TrackID and LastShuffledAt, and modifying the RandomBy* classes to
> accept an optional join table and to specify the datetime column(s)?
> The table could have a third column specifying who's using it, so other plugins
> etc could reuse it.  Could call it CoreTrackShuffles (ShufflerID, TrackID,
> LastShuffledAt)
Comment 1 Gabriel Burt 2009-10-15 21:39:40 UTC 
Created attachment 145558 [details] [review]
Patch

I haven't tested this a ton, so both testing and code review would be great.
Comment 2 Alexander Kojevnikov 2009-10-15 23:50:52 UTC 
Created attachment 145562 [details] [review]
A small fix

Gabriel, the PlayQueueSource has to be updated with this patch otherwise it still changes the LastPlayed stamps.

Other than that, your patch works great both from the play queue and in the library. Thanks!
Comment 3 Gabriel Burt 2009-10-27 20:05:18 UTC 
Comment on attachment 145562 [details] [review]
A small fix

Thanks, committed!