GNOME Bugzilla – Bug 594623
Expose playsink as a fully-fledged element
Last modified: 2009-09-14 10:46:51 UTC
playsink isn't available from outside the playback plugin. Having it available as a fully-fledged element would make it easier to create high-level elements like playbin.
Created attachment 142777 [details] [review] playback: Register playsink as an element. This allows using playsink from outside the playback plugin. Add code to be able to request the sink pads using standard GStreamer API. TODO : expose GObject properties/signals.
Created attachment 142778 [details] [review] GstPlaySink: Expose flags as a gobject property.
Created attachment 142779 [details] [review] GstPlaySink: Expose 'reconfigure' as an action signal.
Good idea, do it :) Will you also expose the "audio-sink" etc stuff as GObject properties to set custom sinks?
yes, that's the last thing I have to expose. Just wanted to make it publicly viewable before I push those commits :)
I *absolutely* want to get this is for the upcoming -base release. I thought I'd have enough time to fix this before the release... but due to the unexpected shift in releases... it'll have to be done faster :( Marking this as blocker.
Created attachment 143141 [details] [review] playsink: Expose mute,volume,vis-plugin and font-desc properties
After going over playbin2's usage of playsink... the remaining properties (*-sink, last-frame) use a lot of code which is in playbin2. My feeling at this point... is that I don't want to do these radical changes for this release but still have playsink exposed. We can still add those remaining properties after the release. Any objections ?
commit b565a3088c9e51346a05b2dd69e68483fe2f2bda Author: Edward Hervey <bilboed@bilboed.com> Date: Mon Sep 14 12:18:33 2009 +0200 playsink: Expose mute,volume,vis-plugin and font-desc properties https://bugzilla.gnome.org/show_bug.cgi?id=594623 commit 377e781ad57e1edbd575227671dfbb808d4b7114 Author: Edward Hervey <bilboed@bilboed.com> Date: Wed Sep 9 12:42:04 2009 +0200 GstPlaySink: Expose 'reconfigure' as an action signal. commit bafe9082fdfabe749b837e8d945cba4b555802f6 Author: Edward Hervey <bilboed@bilboed.com> Date: Wed Sep 9 11:17:28 2009 +0200 GstPlaySink: Expose flags as a gobject property. commit 02c50388c4dd435a601758af4da8bfb70e5836e0 Author: Edward Hervey <bilboed@bilboed.com> Date: Tue Sep 8 11:35:20 2009 +0200 playback: Register playsink as an element. This allows using playsink from outside the playback plugin. Add code to be able to request the sink pads using standard GStreamer API. TODO : expose GObject properties/signals.