GNOME Bugzilla – Bug 594617
Touchpad left-handed bug fixes
Last modified: 2009-09-09 11:49:04 UTC
From https://bugzilla.redhat.com/show_bug.cgi?id=483639 1) Don't swap mouse buttons for left-handers on the touchpad (otherwise a tap would be a right-click) 2) If XInput is supported, don't switch the core pointer to left-handed, as it would cancel our other settings This is the patch for 2.26, if you deem it necessary to have it: http://cvs.fedoraproject.org/viewvc/rpms/gnome-settings-daemon/F-11/gnome-settings-daemon-2.26.1-fix-touchpad.patch?view=markup
Created attachment 142772 [details] [review] patch
Comment on attachment 142772 [details] [review] patch Could you please elaborate on 2)? What's the effect of not swapping the core pointer with XInput, and why do we not want to do that? I think it'd be helpful to spell that out in the comments. Patch looks good.
(In reply to comment #2) > (From update of attachment 142772 [details] [review]) > Could you please elaborate on 2)? What's the effect of not swapping the core > pointer with XInput, The core pointer is the aggregation of all the devices plugged into your system. If you change the configuration of each device through XInput, then change the core pointer, it's as if you didn't do anything. If you don't have XInput support, then the only "device" you have access to is the core pointer. I think it's pretty self-explanatory if you understand what the CorePointer is... > and why do we not want to do that? I think it'd be helpful > to spell that out in the comments.
Committed with slightly better comments. Note that Peter did check this patch, and vouched for it as well. commit 6a3bedfcb9be30b883a145d7e4ce83fd9cbc3e25 Author: Bastien Nocera <hadess@hadess.net> Date: Wed Sep 9 11:59:21 2009 +0100 Bug 594617 - Touchpad left-handed bug fixes 1) Don't swap mouse buttons for left-handers on the touchpad (otherwise a tap would be a right-click) 2) If XInput is supported, don't switch the core pointer to left-handed, as it would cancel our other settings