After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594572 - Needs porting to devkit-power-gobject for suspend/hibernate
Needs porting to devkit-power-gobject for suspend/hibernate
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.27.x
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
: 596569 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-09-08 22:52 UTC by Chris Coulson
Modified: 2009-10-14 15:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add DK-Power support in the greeter (13.94 KB, patch)
2009-09-22 23:11 UTC, Chris Coulson
reviewed Details | Review

Description Chris Coulson 2009-09-08 22:52:11 UTC
Using GDM 2.27.91, the greeter currently displays no hibernate or suspend buttons, despite the machine supporting these. This is because the greeter is using calls to some DBus methods that were recently removed from gnome-power-manager for checking if suspend/hibernate are supported ("org.freedesktop.PowerManagement.Can{Suspend,Hibernate}". Those methods have gone from g-p-m, and the interface name changed to "org.gnome.PowerManager" too).

The greeter should be using libdevkit-power-gobject for checking if suspend/hibernate are supported now. gnome-session already uses this, and will have some example code there. gnome-session also uses this for initiating suspend/hibernate.
Comment 1 Chris Coulson 2009-09-22 23:11:42 UTC
Created attachment 143760 [details] [review]
Add DK-Power support in the greeter

This patch ports the greeter to DK-Power so that suspend works again. It also adds a hibernate button, although I'm not sure if you want that or not.
Comment 2 Vincent Untz 2009-10-02 14:55:51 UTC
See also bug 596569.
Comment 3 Sebastien Bacher 2009-10-07 07:29:32 UTC
*** Bug 596569 has been marked as a duplicate of this bug. ***
Comment 4 Romain Perier 2009-10-11 13:51:23 UTC
And devkit-power is cross-desktop :)
Comment 5 Ray Strode [halfline] 2009-10-14 15:05:01 UTC
Review of attachment 143760 [details] [review]:

Hi Chris,

Thanks for writing this.  There was a smaller patch in bug 596569 which I commited.  I think it might be good to get the fix in the 2.28 branch, but I don't think adding new UI in 2.28 is a good idea. 

The whole suspend/shutdown UI is going to get revisted soon anyway when bug 596151 gets attention.